Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Opening the OneConfig menu (Right Shift) currently puts every HUD into preview mode, because
HudManager.isEditingisisEditorOpen || isConfigUiOpen. While only the menu is open:HudDragLayerdraws an outline around every HUD behind the menu and shows the hover action barisEditingdraw their own edit visuals too. Chatting, for example, draws its chat window edit box and preview lines over the menuThis makes the menu look like a half-open HUD editor, and the HUD outlines overlap the menu panel.
This PR keeps preview and edit mode in the HUD editor only:
HudManager.isEditing(and the internalshowingPreviews) now only followisEditorOpenHudDragLayer, andOneConfigUIScreenno longer draws legacy HUDs as its own underlayOneConfig.prepareHud/submitHudno longer special-caseisConfigUiOpen, so HUDs behind the menu go through the normal live render path, like behind any other screen.overrideShowInScreensis unchanged, so HUDs still show behind the menuHudFrameCacheTest.cacheStaysOnWithScreenOpenUntilEditingnow checks that the menu alone keeps the geometry cache onOpening the HUD editor (Right Shift again in the menu, or Edit HUD) works as before.
Built the 1.8.9 (Ornithe) jar. Not yet tested in game.
Related Issue(s)
None filed.
Checklist
isEditingnow returnsfalsewhile only the menu is open. Mods that relied on it to show previews behind the menu will show live content there insteadHudDragLayeris now unused. I left it in place in case you want to keep it for later, happy to remove it.Note: on
v1without this change, 4 tests in:modules:hudalready fail for me (HudDeletionPersistenceTest, 3 inHudProfileIsolationTest). They fail the same way with this change.