Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In the HUD editor, the hint pill (for example "This HUD is locked · Use the lock button above it to move or resize it") can cover the hovered HUD's action bar, which holds the lock button the hint points to.
hudActionBarLayoutplaces the action bar below the HUD when it fits, and only above it otherwise. The hint placement only kept a fixed 40dp strip above the hovered HUD clear, so when the bar sat below the HUD (the usual case, for example with the chat window), the hint could be placed right on top of it.The hint placement now adds the hovered HUD's real action bar rectangle as an obstacle, wherever the bar ended up.
Built the 1.8.9 (Ornithe) jar. Not yet tested in game.
Related Issue(s)
None filed.
Checklist
oneconfig.hud.hint.lockedtext still says the lock button is "above it" even though it is usually below, which might be worth rewording