Repository navigation
fix(legacy): set the real unlimited framerate on 1.8.9 - #367
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
On 1.8.9 the default settings set the framerate limit to a fixed 260, vanilla's Unlimited. With Argentum (part of OneClient's Performance bundle) the slider goes to 1500 and only 1500 means Unlimited, so 260 is a real cap. Argentum then saves
config/fpslimit.txtas260, and from then on every start keeps the 260 cap: a fresh OneClient 1.8.9 install runs at 260 FPS until the player drags the slider to the end.Newer versions already handle this (
unlimitedFramerateprobes the codec, and thevanilla-framerate-unlimitedtask lifts an old 260 cap). This gives 1.8.9 the same:ClientPlatform.unlimitedFramerateon 1.8.9 is the framerate slider's top (GameOptions.Option.FRAMERATE_LIMIT), atleast 260. Argentum raises that top when the option class loads, so it is 1500 with Argentum and 260 without.
vanilla-framerate-unlimitedtask now also runs on 1.8.9, so installs already stuck at 260 are lifted once, likeon newer versions.
Seen with PolyPlus 2.1.6 and Argentum 1.0.3-beta.13 in OneClient's 1.8.9 bundles: a fresh instance got
fpslimit.txt=260on its first start, and FPS sat at exactly 260 while the same machine reached about 600 with the limit set to Unlimited.Related Issue(s)
None found.
How to test
config/fpslimit.txtsaysunlimitedand the videosettings show Unlimited.
fpslimit.txtof260(andmaxFps:260inoptions.txt): after one start thelimit is Unlimited.
Tested on 1.8.9 with OneClient's bundled mods (offline), comparing the released jar with this branch:
fpslimit.txtis260after the first start.fpslimit.txtisunlimitedafter the first start.260), updated to this branch:unlimitedafter one start, and it staysunlimitedon the next start.Release Notes
Fix the framerate limit on 1.8.9 being set to a real 260 FPS cap instead of Unlimited when Argentum is installed.