Skip to content

fix(legacy): set the real unlimited framerate on 1.8.9 - #367

Merged
Deftu merged 1 commit into
Polyfrost:mainfrom
AlexWeber64:fix/legacy-unlimited-framerate
Nov 19, 2026
Merged

Deftu merged 1 commit into
Polyfrost:mainfrom
AlexWeber64:fix/legacy-unlimited-framerate

Conversation

@AlexWeber64

@AlexWeber64 AlexWeber64 commented Nov 18, 2026 •

Copy link
Copy Markdown
Contributor

Description

On 1.8.9 the default settings set the framerate limit to a fixed 260, vanilla's Unlimited. With Argentum (part of OneClient's Performance bundle) the slider goes to 1500 and only 1500 means Unlimited, so 260 is a real cap. Argentum then saves config/fpslimit.txt as 260, and from then on every start keeps the 260 cap: a fresh OneClient 1.8.9 install runs at 260 FPS until the player drags the slider to the end.

Newer versions already handle this (unlimitedFramerate probes the codec, and the vanilla-framerate-unlimited task lifts an old 260 cap). This gives 1.8.9 the same:

  • ClientPlatform.unlimitedFramerate on 1.8.9 is the framerate slider's top (GameOptions.Option.FRAMERATE_LIMIT), at
    least 260. Argentum raises that top when the option class loads, so it is 1500 with Argentum and 260 without.
  • The vanilla-framerate-unlimited task now also runs on 1.8.9, so installs already stuck at 260 are lifted once, like
    on newer versions.

Seen with PolyPlus 2.1.6 and Argentum 1.0.3-beta.13 in OneClient's 1.8.9 bundles: a fresh instance got fpslimit.txt = 260 on its first start, and FPS sat at exactly 260 while the same machine reached about 600 with the limit set to Unlimited.

Related Issue(s)

None found.

How to test

  1. 1.8.9 with Argentum, fresh instance: after the first start, config/fpslimit.txt says unlimited and the video
    settings show Unlimited.
  2. 1.8.9 with Argentum and an existing fpslimit.txt of 260 (and maxFps:260 in options.txt): after one start the
    limit is Unlimited.
  3. 1.8.9 without Argentum: the limit is vanilla's 260 (Unlimited), as before.

Tested on 1.8.9 with OneClient's bundled mods (offline), comparing the released jar with this branch:

  • Fresh instance, released PolyPlus: fpslimit.txt is 260 after the first start.
  • Fresh instance, this branch: fpslimit.txt is unlimited after the first start.
  • The instance from the first test (stuck at 260), updated to this branch: unlimited after one start, and it stays unlimited on the next start.
  • CI builds all ten versions.

Release Notes

Fix the framerate limit on 1.8.9 being set to a real 260 FPS cap instead of Unlimited when Argentum is installed.

@AlexWeber64
AlexWeber64 marked this pull request as ready for review November 19, 2026 00:21
@Deftu
Deftu merged commit e0dbc7e into Polyfrost:main Nov 19, 2026
@github-project-automation github-project-automation Bot moved this to Done in Poly+ Nov 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants