[Project516]

What this changes

Seven OpenJDK java/text/Collator tests now pass with locale data: DanishTest, FinnishTest, FrenchTest, G7Test, Regression, TurkishTest and VietnameseTest. They go in passing.txt and locale-data.txt (the runner gives them --locale-data), with their times in times.tsv.

Tests

• Each passes twice with --locale-data on current master and fails without it (Danish, Finnish, Turkish and Vietnamese with 2 failures each, French and G7 with 1, Regression with 4), as tests that need locale data should.

[coderabbitai]

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 45 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

Run configuration

• Source mode: Auto
• Repository: Unavailable
• Branch: Unavailable
• File: No configuration file from this repository applied
• Commit: Unavailable
• Layers: Organization UI
• Review profile: ASSERTIVE
• Plan: Advanced
• Run ID: df295f66-eee5-4532-b247-33a25ef2d576

Commits

Reviewing files that changed from the base of the PR and between b3de419 and 3f49260.

Files ignored due to path filters: 1

• test/jtreg/times.tsv is excluded by !**/*.tsv

Files selected for processing: 2

• test/jtreg/locale-data.txt
• test/jtreg/passing.txt

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

• X
• Mastodon
• Reddit
• LinkedIn

[project516-review-bot]

This PR adds seven Collator tests (DanishTest, FinnishTest, FrenchTest, G7Test, Regression, TurkishTest, VietnameseTest) to the jtreg test configuration files. They are added to locale-data.txt (tests requiring --locale-data), passing.txt (tests that pass), and times.tsv (execution times). The changes are purely additive configuration updates with no code logic modifications.

---

_{review-bot, model nvidia/nemotron-3-ultra-550b-a55b:free, verdict approve}