Repository navigation
Update Leiningen to 2.13.1 - #306
Open
cap10morgan wants to merge 3 commits into
Open
cap10morgan wants to merge 3 commits into
cap10morgan wants to merge 3 commits into
Conversation
Pin the 2.13.1 release tag to its commit, d109a01c ("Release 2.13.1").
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Lein builds fetched the release signing key from keyserver.ubuntu.com and failed whenever it timed out, which happens often when building many images in parallel. Import a copy kept in resources/ instead, and still check it against the keyserver: fail with instructions if the keyserver's copy differs (e.g. the key was revoked, extended or gained a subkey), and carry on with the local copy if the keyserver can't be reached. Add `bb refresh-lein-key` to update the local copy from the keyserver. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The lein routing check passes its whole script and Clojure form as arguments, so logging each command printed ~25 lines per image. Log multi-line args as a line count and truncate long ones. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Collaborator
Author
|
@Quantisan I did a little more than just a version bump in here, so wanted your review. Thanks! |
Quantisan
reviewed
Nov 14, 2026
Quantisan
left a comment
Owner
There was a problem hiding this comment.
Thanks! vendoring the key seems reasonable. I'm not sure if it should be code in the image's Dockerfile. Can we do the key server comparison in our CI here, perhaps?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
d109a01c("Release 2.13.1").resources/lein-signing-key.ascand still check it against the keyserver:bb refresh-lein-keybb refresh-lein-key, which fetches the key, checks it's the pinned fingerprint, and writes a minimal export toresources/.Regenerated Dockerfiles aren't included; CI regenerates
target/on master.Testing
bb test(28 tests, 0 failures) andbb fmt-checkpass.latest, with smoke tests viabb build-images.bb refresh-lein-keyleaves an up-to-date key file byte-for-byte unchanged and restores a modified one.🤖 Generated with Claude Code