Repository navigation
fix(api): add start and end anchors to username validation regex - #1424
Open
swarnendusahu10-dotcom wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #1201
In
packages/api/src/EmbeddedChatApi.ts, the regex used to validate usernames inupdateUsernamewas missing an end anchor:/^[0-9a-zA-Z-_.]+/Because it only anchored the start (
^), any string starting with valid characters followed by invalid characters (such asuser!@#$%^&*or trailing spaces) was considered valid. As a result, the function attempted to send the invalid payload to the Rocket.Chat server and threw unhandled API errors instead of falling back toupdateUserNameThroughSuggestion.Changes
/^[0-9a-zA-Z-_.]+$/to enforce full-string validation.updateUserNameThroughSuggestionas originally intended.Type of Change
How Has This Been Tested?
john.doe,user_123,dev-team) -> passed validation.user!@#,valid.name?query=1) -> rejected, safely routed to suggestions.user name,user\nname) -> rejected.packages/api/dist/index.js).