Repository navigation
Updates to the Stage1 paths - #938
Open
mattiasotgia wants to merge 5 commits into
Open
mattiasotgia wants to merge 5 commits into
mattiasotgia wants to merge 5 commits into
Conversation
cerati
approved these changes
Nov 12, 2026
cerati
left a comment
Contributor
There was a problem hiding this comment.
looks good. There is still the opportunity to clean up a bit spine_gaushit_parameters but that can be done once those parameters are finalized
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview and references
This PR re-work the
stage1paths for Pandora + NuGraph2 + Pandora and SPINE reconstruction.Details are in SBN DocDB 50214, and where discussed at the ICARUS sim/reco and meeting.
The idea is essentially to split the reconstruction chain into three paths:
cluster3Dwhich is required to haveSpacePoints);Key changes
Stage1 definitions (
stage1_icarus_defs.fcl)cluster3DCryoW/Eis the SPINE version and reads thegaushitPT2dTPC*hits.pandoraCluster3DCryoW/Eis for Pandora + NG2 + Pandora and reads the plaingaushit2dTPC*hits.icarus_reco_pandoraCluster3DCryo{W,E}sequences and to theGauss2Dsequences.gaushitPT2dTPC*hit finders now take a sharedspine_gaushit_parametersblock instead of justLongMaxHits. It adds back the default values for the hit finder algorithm (MaxMultiHit: 5,hi2NDF: 500.,LongPulseWidth: [10, 10, 10]) as well as the default for the candidate-hit tool (RoiThreshold: 5.andNextADCThreshold: 0).pandoraGausCryo*input is nowpandoraCluster3DCryo*.Stage1 data and MC job configs
*_1d_*) also set thegaushit1d*tags forpandoraCluster3D*, so Pandora with 1D signal processing uses them too.stage1_run2_icarus.fcland its_MCversion) pointpandoraGausCryo*back tocombineHits*.pandoraCluster3D*forpandoraGausCryo*.NuGraph (
nugraph_icarus.fcl)SpsLabel,ClusterLabeland thehitInputlabels for the slice-hit, NCC-slice and multi-slice modules now usepandoraCluster3DCryo*, aligned with the Pandora-specific Cluster3D instance.Notes
This PR overrides (and expands) the previous PR