Repository navigation
Move release.yml artifact steps off Node 20 actions - #2027
Mikola Lysenko (mikolalysenko) wants to merge 1 commit into
Conversation
release.yml was the last workflow still pinning upload-artifact and download-artifact v4, which target the deprecated Node.js 20 runtime (#1588). GitHub forces them onto Node 24 for now; when Node 20 action support is removed, the release build and github-release jobs would break at publish time, and release is the one workflow no PR exercises. Pin the same releases every other workflow already uses: upload-artifact v6.0.0 (b7c566a) and download-artifact v7.0.0 (37930b1). The download step lists every artifact of the run with path + merge-multiple, which ci.yml already does with v7, and the by-artifact-ID path change in v5 doesn't apply. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_011f9aeR1h6tkiHFXbvuNbrv
|
bugbot run Generated by Claude Code |
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit 20ecb62. Configure here.
|
Ready for review at head
Generated by Claude Code |
Final review briefWhat it does. Risk: low. It changes three action pins and nothing else. The new SHAs are the ones Look here
Verified
Changes I made: none. Open questions: none. Optional: after merge, run the release dry run ( Auto-merge is armed, so approving sends this straight to the merge queue. Generated by Claude Code |
Fixes #1588.
Problem
#1588 tracks pinned actions that target the deprecated Node.js 20 runtime. Every workflow except one has since moved to Node 24 releases.
release.ymlstill pins:actions/upload-artifact@ea165f8… # v4(2 uses, build job)actions/download-artifact@d3f86a1… # v4(1 use, github-release job)GitHub forces these onto Node 24 for now. When it drops Node 20 action support, the release build and
github-releasejobs break at publish time. Release is the only workflow no PR or merge_group run exercises, so we'd find out mid-release (last run: 2026-10-13).Fix
Pin the releases every other workflow already uses, at the same SHAs:
ea165f8v4b7c566av6.0.0d3f86a1v437930b1v7.0.0Breaking changes I checked:
path+merge-multiple: true, which ci.yml already does with v7.0.0 (lines 909, 2326).Proof
git ls-remote:refs/tags/v6.0.0=b7c566a…,refs/tags/v7.0.0=37930b1….ea165f8ord3f86a1.uses:is a 40-char SHA.Owner note: the release dry-run path (
workflow_dispatchwithdry-run: true) builds and uploads artifacts, so a dry run after merge would exercise the new upload pin end to end.https://claude.ai/code/session_011f9aeR1h6tkiHFXbvuNbrv
Generated by Claude Code