Repository navigation
keep scroll from flicker and new profile - #823
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues are recorded for the change intended to reduce scroll flicker during height-only viewport updates.
No open issues 🎉
What changed in this PR
This PR reduces scroll flicker by preventing main-page rerenders when only the viewport height changes.
Changes:
- Excludes viewport height from the render-environment signature while retaining width, layout, theme, and input mode.
- Adds a regression test confirming height-only changes do not trigger page navigation or rerendering.
| File | Description |
|---|---|
test/unit/mainPage/index.test.ts |
Tests that height-only viewport changes skip rerendering. |
src/mainPage/index.ts |
Removes viewport height from the render-environment signature. |
Review effort: Balanced
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.