Skip to content

fix: reject empty negative binary input #15689

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Yash4305d-y wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: reject empty negative binary input #15689

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion conversions/binary_to_decimal.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,14 @@ def bin_to_decimal(bin_string: str) -> int:
Traceback (most recent call last):
...
ValueError: Empty string was passed to the function
>>> bin_to_decimal("-")
Traceback (most recent call last):
...
ValueError: Non-binary value was passed to the function
>>> bin_to_decimal(" - ")
Traceback (most recent call last):
...
ValueError: Non-binary value was passed to the function
>>> bin_to_decimal("39")
Traceback (most recent call last):
...
Expand All @@ -29,7 +37,7 @@ def bin_to_decimal(bin_string: str) -> int:
is_negative = bin_string[0] == "-"
if is_negative:
bin_string = bin_string[1:]
if not all(char in "01" for char in bin_string):
if not bin_string or not all(char in "01" for char in bin_string):
raise ValueError("Non-binary value was passed to the function")
decimal_number = 0
for char in bin_string:
Expand Down
Loading