Repository navigation
Conversation
Deploying ucdcweb2 to TEST failed after a Drupal core upgrade from 11.1 to 11.4: cache-rebuild ran before drush deploy, so the new core code rebuilt its router against the live database's old schema and hit "Unknown column 'alias'". The earlier fix only covered major upgrades, but minor releases change the schema too. drush deploy already runs updatedb before config:import and cache:rebuild, so drop the cache-rebuild in front of it, the pre-deploy env:clear-cache (which fails the same way after a stalled deploy), and the major-version detection that only existed to work around them. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
kurowski
marked this pull request as draft
November 12, 2026 17:32
Member
Author
|
see comments here https://github.com/UCEAP/.github-private/wiki/Developer-Meeting-Agenda-2026-11-12#deployment-change and think REAL HARD about them before merging |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Deploy to TEST for ucdcweb2 failed after a Drupal core upgrade from 11.1.10 to 11.4.11:
_pantheon_complete_deploymentrunscache-rebuildbeforedrush deploy. Against LIVE's synced database, the new core rebuilt the router before its update hook had added therouter.aliascolumn. The deploy then stopped with TEST still in maintenance mode.1780e49 and f0a549d already handled this, but only for major upgrades. Minor releases change the schema too.
Change
drush deployalready runsupdatedb, thenconfig:import, thencache:rebuild, so nothing needs to rebuild caches before it. This PR removes:cache-rebuildbeforedrush deployenv:clear-cachebeforeenv:deploy, which fails the same way when an earlier deploy stalled with new code on the old schema (the cache clear at the end still runs)_drupal_major_upgrade_pendingand the extraupdatedb, which only worked around the two calls aboveThe TEST/LIVE deploy is now: maintenance on →
env:deploy→drush deploy→ maintenance off →env:clear-cache. The training deploy also calls_pantheon_complete_deploymentand gets the same fix.Testing
Only
bash -nhas been run so far. To verify: after this image is published, run a normal (sync) Deploy to TEST on ucdcweb2. LIVE is still on 11.1, so this reproduces the original failure and should now pass. Do this before ucdcweb2 deploys to LIVE.🤖 Generated with Claude Code