Repository navigation
Use explicit 3.0 version in logo - #297
camillobruni wants to merge 2 commits into
Conversation
✅ Deploy Preview for webkit-jetstream-preview ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
danleh
left a comment
danleh
left a comment
There was a problem hiding this comment.
LGTM with nit. Lets also update the main branch afterwards (this PR goes to the 3.0 branch directly)
There was a problem hiding this comment.
tiny typography nit: Could you very slightly reduce the letter spacing around the . in 3.0?
|
I don't have super strong feelings about this but one downside is that incremental updates require touching up the logo. I kinda prefer the paragraph at the top so we can quickly roll out the number. |
|
It would be in sync with speedometer where we did the same change (though the "logo" is just text): It would just eliminate an easy source of error if we ever do an incremental dot-release. |
What easy source of error are you thinking? That we copy the wrong branch? I guess I'd prefer to make this change in 3.1 (if needed). |
|
Mostly about accidentally using the wrong minor version without noticing since the log doesn't feature the number immediately. It's a bit less of an issue with jetstream since it does mention the minor version in the text. In the past these two were pretty easy to confuse (since it's only in the tab title). |
7512beb to
de004c2
Compare
de004c2 to
f15017d
Compare
This makes it easier to spot minor fixes in the future.