Repository navigation
Fix Clean Up window freezing when expanding sections - #893
Open
oguzhanvarsak wants to merge 1 commit into
Open
oguzhanvarsak wants to merge 1 commit into
oguzhanvarsak wants to merge 1 commit into
Conversation
The cleanup list nested LazyVStacks: an outer one in the window's ScrollView whose cells are section cards, and an inner one per expanded card. After expanding a few sections, scrolling or toggling items left the main thread stuck in SwiftUI layout (repeated LazyVStack size estimates and item phase updates, amplified by hover updates), so the window stopped responding. Use eager VStacks instead. Collapsed sections still build no rows, and typical sections hold tens of rows. Very large folders (~1,000 entries) no longer freeze but still scroll slowly; that needs separate work.
oguzhanvarsak
marked this pull request as ready for review
November 16, 2026 10:43
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #892
Problem
After expanding a few sections in the Clean Up window and scrolling (or toggling items), the window freezes and the main thread stays at ~100% CPU. The cleanup list nests lazy stacks (a
ScrollView > LazyVStackof section cards, each with anotherLazyVStackof rows), and SwiftUI gets stuck re-laying them out.Change
Use
VStackinstead ofLazyVStackfor the section list inCleanupWindowand for the rows inCleanupCategorySectionandCleanupRuntimeSection. Making only the inner stacks eager wasn't enough; the outer one has to be eager too. Collapsed sections still build no rows.Testing
main(Debug and Release) by expanding sections such as Derived Data and Simulator devices and scrolling. With this change it no longer reproduces, and asampleright after scrolling and toggling shows the main thread idle.xcodebuild test -scheme Xcodes: 126 tests, 0 failures (3 skipped).Known limitation
Very large sections (~1,000 entries) no longer freeze but still scroll slowly; that needs separate work. Details and the other approach I tried are in #892 (comment).