Repository navigation
docs: add Windows Docker installation instructions - #2427
gunjansonaw wants to merge 1 commit into
Conversation
f3cddd8 to
991e20c
Compare
| Create ``docker-compose.override.yml`` with the configuration mount for the | ||
| application, scheduler, and both RQ workers:: | ||
|
|
||
| services: | ||
| vulnerablecode: | ||
| volumes: | ||
| - .\vulnerablecode-config:/etc/vulnerablecode/ | ||
| vulnerablecode_scheduler: | ||
| volumes: | ||
| - .\vulnerablecode-config:/etc/vulnerablecode/ | ||
| vulnerablecode_rqworker: | ||
| volumes: | ||
| - .\vulnerablecode-config:/etc/vulnerablecode/ | ||
| vulnerablecode_rqworker_high: | ||
| volumes: | ||
| - .\vulnerablecode-config:/etc/vulnerablecode/ |
There was a problem hiding this comment.
It might be a good idea to have a special Docker Compose file for Windows, docker-compose.windows.yml
| Create ``docker-compose.override.yml`` with the configuration mount for the | |
| application, scheduler, and both RQ workers:: | |
| services: | |
| vulnerablecode: | |
| volumes: | |
| - .\vulnerablecode-config:/etc/vulnerablecode/ | |
| vulnerablecode_scheduler: | |
| volumes: | |
| - .\vulnerablecode-config:/etc/vulnerablecode/ | |
| vulnerablecode_rqworker: | |
| volumes: | |
| - .\vulnerablecode-config:/etc/vulnerablecode/ | |
| vulnerablecode_rqworker_high: | |
| volumes: | |
| - .\vulnerablecode-config:/etc/vulnerablecode/ |
There was a problem hiding this comment.
Added the dedicated docker-compose.windows.yml override and updated the Windows instructions to use it explicitly.
| .. warning:: | ||
| On **Windows** VulnerableCode can **only** :ref:`run_with_docker` and is not supported. | ||
|
|
There was a problem hiding this comment.
Why do we need to remove that?
There was a problem hiding this comment.
I retained and clarified the warning: native Windows installation is not supported, while Docker Desktop is supported. It now points to the Docker installation instructions.
2237aa2 to
f8ab85d
Compare
0ea4bf2 to
2bcccf4
Compare
Signed-off-by: Gunjan Sonawane <gunjansonawane462@gmail.com>
2bcccf4 to
b4d186c
Compare
|
@ziadhany I've addressed your review comments:
Tested from a fresh clone with an empty database on Windows with Docker Desktop: all migrations applied, all 7 services running, and http://localhost returns HTTP 200. Could you take another look when you have time? Thanks! |
Summary
.envcontents forSECRET_KEYandALTCHA_HMAC_KEYwith placeholder values (no secret generation), sincemake envfileis not available on Windows.docker-compose.windows.ymlto mount./vulnerablecode-configas/etc/vulnerablecode/.vulnerablecode-config/so secrets are never committed.Testing
git diff --checkpasses.Notes
The Windows instructions are Docker-based because native Windows installation is not supported.