Repository navigation
Remove v1 code - #2469
Open
TG1999 wants to merge 6 commits into
Open
Remove v1 code#2469TG1999 wants to merge 6 commits into
TG1999 wants to merge 6 commits into
Conversation
Contributor
Author
|
#2469 PR is in progress here |
keshav-space
requested changes
Oct 16, 2026
keshav-space
left a comment
keshav-space
left a comment
Member
There was a problem hiding this comment.
Thanks @TG1999, see few nits below.
Comment on lines
+26
to
+39
| <script> | ||
| function goToTab(tabName) { | ||
| var tabs = document.getElementById('tabs'); | ||
| if (!tabs) return false; | ||
| var targetLink = tabs.querySelector('[data-tab="' + tabName + '"]'); | ||
| var targetContent = document.querySelector('#tab-content > .tab-div[data-content="' + tabName + '"]'); | ||
| if (!targetLink || !targetContent) return false; | ||
| tabs.querySelectorAll('li.is-active').forEach(function (el) { el.classList.remove('is-active'); }); | ||
| document.querySelectorAll('#tab-content > .tab-div.is-active').forEach(function (el) { el.classList.remove('is-active'); }); | ||
| targetLink.classList.add('is-active'); | ||
| targetContent.classList.add('is-active'); | ||
| return false; | ||
| } | ||
| </script> |
Member
There was a problem hiding this comment.
Why do we need to move script to the middle? It should be at the bottom of template, inside {% block scripts %}. Moreover we should not duplicate this script, we should instead reuse <script src="{% static 'js/main.js' %}"></script>
Signed-off-by: Tushar Goel <tushar.goel.dav@gmail.com>
Signed-off-by: Tushar Goel <tushar.goel.dav@gmail.com>
Signed-off-by: Tushar Goel <tushar.goel.dav@gmail.com>
Signed-off-by: Tushar Goel <tushar.goel.dav@gmail.com>
Signed-off-by: Tushar Goel <tushar.goel.dav@gmail.com>
Signed-off-by: Tushar Goel <tushar.goel.dav@gmail.com>
TG1999
force-pushed
the
remove_v1_code
branch
from
November 4, 2026 08:43
32614e0 to
456f2ce
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes vulnerability model and related importers/improvers completely from VCIO codebase.