Repository navigation
Conversation
In a Git worktree the development server keeps its Vite cache in the worktree's own cache directory while the configured path resolves to the shared cache of the main checkout. `ng cache clean` removes both since the `getCacheConfig` localPath addition, but `ng cache info` still reports only the shared path and its size, so the cache that the development server actually writes to in that checkout is invisible. Print the local path and its size when it differs from the shared path. Outside of a worktree both paths are the same and the output is unchanged. Tested with a unit spec that reproduces the worktree layout; the spec fails without the fix.
There was a problem hiding this comment.
Code Review
This pull request updates the cache info command to display both the shared cache path and the worktree-local cache path (along with its size on disk) when running inside a Git worktree. It also adds comprehensive unit tests to verify this behavior in both standard repositories and Git worktrees. The feedback suggests parallelizing the directory size calculations for the shared and local cache paths using Promise.all to improve performance by avoiding sequential disk I/O operations.
clydin
approved these changes
Nov 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In a Git worktree the development server keeps its Vite cache in the worktree's own cache directory while the configured path resolves to the shared cache of the main checkout.
ng cache cleanremoves both since thegetCacheConfiglocalPath addition, butng cache infostill reports only the shared path and its size, so the cache that the development server actually writes to in that checkout is invisible.Print the local path and its size when it differs from the shared path. Outside of a worktree both paths are the same and the output is unchanged.