Repository navigation
Conversation
…a foreign message On a strict connection, sending a message from another provider failed with MessageNotWriteableException when that message listed a property such as JMSXDeliveryCount. The conversion now leaves those properties out on a strict connection. transformMessage and copyProperties have an overload that takes a strictComplianceOverride flag. True copies the provider-set values even on a strict connection, for example when bridging. The consumer passes true for a message returned by a consumer transformer, since that message is on its way to the application. The set of property names is renamed to JMSX_PROVIDER_PROPERTIES.
mattrpav
changed the title
mattrpav
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is ready and slides the behavior behind the strictCompliance flag.
Background
Provider-specific JMSX properties should not be allowed to be set by application code. ActiveMQ previously allowed this, so throwing an exception would be a SEMVER violation without a major version update.
This changes allows ActiveMQ to become more Jakarta compliant in a minor release, while also retaining the ability to perform an administrative copy at times that includes thos values. For example, a bridge or migration may want to copy those headers across from one JMS system to another.
Related
replaces [#1853]