Repository navigation
Upgrade DataFusion to version 56 - #1826
Open
nuno-faria wants to merge 3 commits into
Open
nuno-faria wants to merge 3 commits into
nuno-faria wants to merge 3 commits into
Conversation
nuno-faria
commented
Nov 7, 2026
Contributor
Author
There was a problem hiding this comment.
Contributor
Author
There was a problem hiding this comment.
Contributor
Author
There was a problem hiding this comment.
| } | ||
|
|
||
| /// Retrieves the right input `LogicalPlan` to this `Join` node | ||
| /// Retrieves the equality keys of this `Join` node |
Contributor
Author
There was a problem hiding this comment.
Noticed when creating the ASOF join that the prev comment was wrong.
Contributor
Author
There was a problem hiding this comment.
| &self, | ||
| _ctx: &dyn Session, | ||
| projection: Option<&Vec<usize>>, | ||
| projection: Option<&[usize]>, |
Contributor
Author
There was a problem hiding this comment.
Comment on lines
5352
to
+5388
| @@ -5385,7 +5385,7 @@ def map_entries(map: Expr) -> Expr: | |||
| def element_at(map: Expr, key: Expr) -> Expr: | |||
| """Returns the value for a given key in the map. | |||
| Returns ``[None]`` if the key is absent. | |||
| Returns ``[]`` if the key is absent. | |||
Contributor
Author
There was a problem hiding this comment.
|
|
||
| def test_sql_with_options_no_statements(ctx): | ||
| sql = "SET time zone = 1;" | ||
| sql = "SET time zone = 'UTC';" |
Contributor
Author
There was a problem hiding this comment.
Timezone is now validated.
Comment on lines
1792
to
+1814
| @@ -1811,7 +1811,7 @@ def test_read_csv_with_options(tmp_path, as_read, global_ctx): | |||
| [ | |||
| pa.array(["Alice", "Bob", "Phil", "Karin"]), | |||
| pa.array([30.0, 25.0, 75.0, 50.0]), | |||
| pa.array(["New York; NY", None, "Detroit' MI", "Stockholm\nSweden"]), | |||
| pa.array(["New York; NY", "", "Detroit' MI", "Stockholm\nSweden"]), | |||
Contributor
Author
There was a problem hiding this comment.
This now appears as an empty string since it does not match the null_regex. From apache/datafusion#25254
Comment on lines
+2722
to
+2724
| with pytest.raises( | ||
| Exception, match=r"Invalid compression level \d+ for \w+\. Expected a level" | ||
| ): |
Contributor
Author
There was a problem hiding this comment.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
N/A.
Rationale for this change
A new DataFusion version is being released: apache/datafusion#24461
What changes are included in this PR?
There are new types like
Show(which replacedDescribeTable),AsOfJoin, andMaterializedCte, as well as some other minor changes. I will add them as comments.Are there any user-facing changes?
New DF version. Other than that the main breaking change is that
DescribeTablehas been removed. I added a note to the upgrade guide.