Skip to content

ci(lint): drop obsolete aws-sdk-go v1 exclusion for kiro - #9339

Open
DoDiODev wants to merge 1 commit into
apache:mainfrom
DoDiODev:pr/golangci-drop-kiro-aws-v1-exclusion
Open

DoDiODev wants to merge 1 commit into
apache:mainfrom
DoDiODev:pr/golangci-drop-kiro-aws-v1-exclusion

Conversation

@DoDiODev

@DoDiODev DoDiODev commented Nov 7, 2026

Copy link
Copy Markdown
Contributor

⚠️ Pre Checklist

Please complete ALL items in this checklist, and remove before submitting

  • I have read through the Contributing Documentation.
  • I have added relevant tests. (N/A: config-only change; the existing
    golangci-lint job covers it)
  • I have added relevant documentation. (N/A)
  • I will add labels to the PR, such as pr-type/bug-fix, pr-type/feature-development, etc.

Summary

backend/.golangci.yaml still carries a staticcheck exclusion that was
added in #9197 as a stopgap:

# aws-sdk-go v1 is end-of-support and its last release marks every
# package as deprecated. Tolerate that only for the kiro plugin until it
# is migrated to aws-sdk-go-v2; remove this rule afterwards.
- linters:
    - staticcheck
  path: plugins/kiro/
  text: 'SA1019: "?github.com/aws/aws-sdk-go/'

The migration it waits for landed in #9233. Since then the backend no
longer imports github.com/aws/aws-sdk-go (v1) anywhere, and go.mod /
go.sum only contain aws-sdk-go-v2 modules. The rule now matches nothing.

This PR removes it, as its own comment asks. If someone reintroduces a v1
import, golangci-lint reports it again instead of silently ignoring it.

Does this close any open issues?

N/A (follow-up to #9197 and #9233)

Screenshots

N/A

Other Information

  • golangci-lint config verify passes, and make mock && make lint with
    golangci-lint v2.15.0 (the CI version) reports 0 issues.
  • Fork CI on the same change (golangci-lint, unit-test, e2e on MySQL and
    PostgreSQL, config-ui, license header, Grafana check; 16/16 jobs green):
    https://github.com/DoDiODev/devlake/actions/runs/42363913171

The staticcheck SA1019 exclusion for github.com/aws/aws-sdk-go in
plugins/kiro/ was added in apache#9197 as a stopgap until kiro moved to
aws-sdk-go-v2. That migration landed in apache#9233, and the backend no longer
imports aws-sdk-go v1 at all, so the rule matches nothing. Remove it as
its own comment asks, so a reintroduced v1 import is reported again.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant