Repository navigation
Conversation
The staticcheck SA1019 exclusion for github.com/aws/aws-sdk-go in plugins/kiro/ was added in apache#9197 as a stopgap until kiro moved to aws-sdk-go-v2. That migration landed in apache#9233, and the backend no longer imports aws-sdk-go v1 at all, so the rule matches nothing. Remove it as its own comment asks, so a reintroduced v1 import is reported again. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
golangci-lint job covers it)
pr-type/bug-fix,pr-type/feature-development, etc.Summary
backend/.golangci.yamlstill carries a staticcheck exclusion that wasadded in #9197 as a stopgap:
The migration it waits for landed in #9233. Since then the backend no
longer imports
github.com/aws/aws-sdk-go(v1) anywhere, andgo.mod/go.sumonly containaws-sdk-go-v2modules. The rule now matches nothing.This PR removes it, as its own comment asks. If someone reintroduces a v1
import, golangci-lint reports it again instead of silently ignoring it.
Does this close any open issues?
N/A (follow-up to #9197 and #9233)
Screenshots
N/A
Other Information
golangci-lint config verifypasses, andmake mock && make lintwithgolangci-lint v2.15.0 (the CI version) reports
0 issues.PostgreSQL, config-ui, license header, Grafana check; 16/16 jobs green):
https://github.com/DoDiODev/devlake/actions/runs/42363913171