Repository navigation
mod_lua: Restrict LuaRoot to RSRC_CONF to fix per-dir pool lifetime bug - #1029
Open
fattylin0110 wants to merge 2 commits into
Open
fattylin0110 wants to merge 2 commits into
fattylin0110 wants to merge 2 commits into
Conversation
register_root_dir() stores the resolved LuaRoot path pointer into the server-level configuration (ap_lua_server_cfg on parms->server->module_config) rather than the per-directory configuration. When LuaRoot is used in an .htaccess file (permitted by OR_ALL), parms->pool is the transient request pool (r->pool), causing cross-request server config pollution and leaving a dangling pointer in server_cfg->root_path once the request pool is cleared. Restrict LuaRoot to RSRC_CONF to match its server-scoped implementation.
Update the manual for the LuaRoot context change and add a CHANGES entry, since existing configurations which used the directive in <Directory> or .htaccess will now fail to start. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
register_root_dir() stores the resolved LuaRoot path pointer into the server-level configuration (ap_lua_server_cfg on parms->server->module_config) rather than the per-directory configuration.
When LuaRoot is used in an .htaccess file (permitted by OR_ALL), parms->pool is the transient request pool (r->pool), causing cross-request server config pollution and leaving a dangling pointer in server_cfg->root_path once the request pool is cleared.
Restrict LuaRoot to RSRC_CONF to match its server-scoped implementation.
(see
SECURITY.mdandhttps://www.apache.org/security/#reporting-a-vulnerability).
APLOGNO()tag;numbers are assigned by a committer at merge time (see
docs/log-message-tags/README).changes-entries/*.txtfile is included,following the template in
README.CHANGES(not needed otherwise).test/modules/xxxdirectory matching themodules/xxxmodule source,or
test/modules/corefor core server changes. On Unix, verify thesepass locally with e.g.
make check-pytest PYTEST_DIRS=test/modules/xxx.