Repository navigation
Conversation
This was referenced Nov 14, 2026
manuzhang
force-pushed
the
codex/manifests-metadata-table-20261115
branch
from
November 15, 2026 15:26
6fd948c to
9689cbf
Compare
Extract a focused piece from the metadata table implementation with its tests. Co-authored-by: Codex <codex@openai.com>
manuzhang
force-pushed
the
codex/manifests-metadata-table-20261115
branch
from
November 15, 2026 15:29
9689cbf to
0c8449b
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on #1120 (scan contracts/tasks) and #1133 (lazy Arrow batching). Apply those prerequisites when building this draft; merge them first, then rebase this branch onto main. This table is independent of FilesTable and PartitionsTable.
Add
ManifestsTablethroughTable::Inspect(MetadataTableKind::kManifests). Rows expose manifest paths, content, sizes, spec/snapshot IDs, nullable data/delete file counts, and readable partition summaries.Scans retain metadata/projection/FileIO and support reordered or empty whole-column projections and configurable batches. Partition bounds recover dropped source-column types from retained schema history, including identity/truncate transforms and numeric promotion. Partition types are cached per spec within a scan.
The shared scan test fixture accompanies its real consumers; identical copies in the other table drafts disappear on rebase once the fixture lands.
Validation with the stated prerequisites applied: all 79 metadata tests and C++20 compatibility passed. Feature-specific code and factory were compiled and linked against the separately built helper foundation, without the partition-helper or live-file-helper tests. Pre-commit and clang-tidy 22.1.8 passed.