Repository navigation
Conversation
Extract a focused piece from the metadata table implementation with its tests. Co-authored-by: Codex <codex@openai.com>
This was referenced Nov 15, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Metadata tables need one consistent partition struct across evolved specs. Add shared helpers to build that union, project values by field ID, preserve nulls, promote primitive values, and append partition/literal values to Arrow builders.
Use the newest field names, retain compatible non-void transforms, and reject conflicting definitions. Focused tests cover schema evolution and promotion, conflicting field IDs, value counts, and Arrow serialization with nulls.
Extracted from #1120. Builds directly on main and has no dependency on the scan/task or live-file helpers.
Validation: 58 metadata tests and C++20 compatibility passed in a standalone static Debug build. Pre-commit and clang-tidy 22.1.8 passed. Partition tests also passed in the combined shared-library build. The full split composition passed 144 tests with one expected format-version skip.