Repository navigation
Conversation
Extract a focused piece from the metadata table implementation with its tests. Co-authored-by: Codex <codex@openai.com>
This was referenced Nov 15, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Metadata-table readers need live files from a snapshot without reading every manifest up front. Add
LiveFiles, which opens one manifest at a time, filters deleted entries, supports selected file columns, and retains the schema, partition specs, and FileIO needed by the stream.Tests exercise format versions 1/2/3, multiple manifests, retained input ownership, deferred reads, sticky read failures, and empty snapshots. Each individual manifest is still materialized by
ManifestReader::LiveEntries.Extracted from #1120. Builds directly on main. Snapshot selection stays with scan validation in #1120; this PR only supplies live-file iteration.
Validation: 64 metadata tests and C++20 compatibility passed in a standalone static Debug build. Pre-commit and clang-tidy 22.1.8 passed. The full split composition passed 144 tests with one expected format-version skip.
Shared-library build and C++20 linkage passed. The local shared Debug runtime check hits
std::bad_castin existing Avro encoding while writing test fixtures, before the new helper runs; the same failure reproduces in unchanged main V1/V2/V3 manifest-writer tests. This split does not change those writer/encoder implementations.