Repository navigation
feat(encryption): [12/N] Read encrypted deletion vectors - #4326
Merged
kevinjqliu merged 1 commit intoNov 10, 2026
Merged
Conversation
A Puffin delete file's key_metadata holds the plaintext key metadata of its AGS1 stream, so deletion vector reads decrypt with it when it is set, as iceberg-rust does. Content offsets refer to the decrypted file.
xanderbailey
marked this pull request as ready for review
November 10, 2026 13:43
kevinjqliu
approved these changes
Nov 10, 2026
Comment on lines
+160
to
+162
| if dv.key_metadata is not None: | ||
| return EncryptedInputFile(input_file, StandardKeyMetadata.from_bytes(dv.key_metadata)) | ||
| return input_file |
Contributor
There was a problem hiding this comment.
nit: we might want to refactor this (later) since this repeats the same logic as ManifestFile.fetch_manifest_entry()
We could potentially share a helper in pyiceberg/encryption/io.py that accepts an InputFile and optional key-metadata bytes, then reuse it in both places. Non-blocking.
Contributor
|
thanks @xanderbailey |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Working towards #3222
Rationale for this change
We need to be able to read deletion vectors stored in encrypted Puffin files.
Are these changes tested?
Yes. A Puffin file with one deletion vector, encrypted by iceberg-rust, is checked in under
tests/table/encryption.Are there any user-facing changes?
No. Nothing changes for unencrypted tables.