Skip to content

Do not send more data than the content-length of an HTTP/2 response - #1244

Open
arturobernalg wants to merge 1 commit into
apache:mainfrom
arturobernalg:h2-response-content-length
Open

arturobernalg wants to merge 1 commit into
apache:mainfrom
arturobernalg:h2-response-content-length

Conversation

@arturobernalg

Copy link
Copy Markdown
Member

RFC 9113, section 8.1.1 states that a response is malformed if the value of the content-length header field is not the sum of the DATA frame payloads, and clients such as curl and browsers reset the stream.

When an application wrote more data than the content length it had set, for example because it counted characters rather than bytes, HTTP/2 sent all of the data. HTTP/1.1 discards the data beyond the content length.

This discards the data beyond the content length in the HTTP/2 stream output buffer as well.

Tested with a running Tomcat and a raw HTTP/2 client with a content length of 5: without the change 10 bytes (or 6 when written in pieces) were sent in the DATA frames, with the change 5. A body of exactly the content length is not affected.

RFC 9113, section 8.1.1 states that a response is malformed if the value
of the content-length header field is not the sum of the DATA frame
payloads, and clients such as curl and browsers reset the stream. An
application that wrote more than the content length it had set, for
example because it counted characters rather than bytes, had all of the
data sent. HTTP/1.1 discards the data beyond the content length.

Discard the data beyond the content length in the HTTP/2 stream output
buffer as well.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant