Repository navigation
Do not send more data than the content-length of an HTTP/2 response - #1244
Open
arturobernalg wants to merge 1 commit into
Open
arturobernalg wants to merge 1 commit into
arturobernalg wants to merge 1 commit into
Conversation
RFC 9113, section 8.1.1 states that a response is malformed if the value of the content-length header field is not the sum of the DATA frame payloads, and clients such as curl and browsers reset the stream. An application that wrote more than the content length it had set, for example because it counted characters rather than bytes, had all of the data sent. HTTP/1.1 discards the data beyond the content length. Discard the data beyond the content length in the HTTP/2 stream output buffer as well.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RFC 9113, section 8.1.1 states that a response is malformed if the value of the content-length header field is not the sum of the DATA frame payloads, and clients such as curl and browsers reset the stream.
When an application wrote more data than the content length it had set, for example because it counted characters rather than bytes, HTTP/2 sent all of the data. HTTP/1.1 discards the data beyond the content length.
This discards the data beyond the content length in the HTTP/2 stream output buffer as well.
Tested with a running Tomcat and a raw HTTP/2 client with a content length of 5: without the change 10 bytes (or 6 when written in pieces) were sent in the DATA frames, with the change 5. A body of exactly the content length is not affected.