Skip to content

[Fix][Build] Accept the pinned TIRx 0.1.0 release - #20980

Closed
hiyufan wants to merge 1 commit into
apache:mainfrom
hiyufan:fix/tirx-010-release-compat
Closed

hiyufan wants to merge 1 commit into
apache:mainfrom
hiyufan:fix/tirx-010-release-compat

Conversation

@hiyufan

@hiyufan hiyufan commented Nov 15, 2026

Copy link
Copy Markdown
Contributor

The pinned TIRx commit f43b3030d33196d3a5f21e56b37549a6d3a5c70b now carries the v0.1.0 release tag. After CI fetches tags, its source-built wheel is apache-tvm-tirx==0.1.0. TVM still accepts only 0.1.0rc2/0.1.0rc3, so the parent wheel fails to configure on both macOS and Windows before running tests:

TVM requires apache-tvm-tirx 0.1.0rc2 or 0.1.0rc3

Examples: macOS job, Windows job. The same error occurs in all five refreshed PRs #20815, #20816, #20817, #20818 and #20819.

Accept the final 0.1.0 release in the installed-package CMake check and align the build/runtime Python dependency bounds. Keep support for rc2/rc3 and cap the dependency at 0.1.0; later patch/minor versions remain excluded. The pinned TIRx source commit is unchanged.

Validation on Linux aarch64:

  • Installed-package CMake configuration against the staged, source-built pinned TIRx libraries and actual SCM version 0.1.0: unchanged main fails with the CI error; the patched tree configures successfully.
  • Ten version cases check the actual CMake guard and both Python requirement sets: rc1/dev/post/0.1.1/0.2.0 are rejected; rc2/rc3 (including hyphenated spellings) and the final release are accepted.
  • Generated wheel metadata through the build backend and verified that Requires-Dist accepts 0.1.0 and rejects 0.1.1.
  • File-scoped pre-commit checks and Taplo 0.9.3 passed.

Native macOS/Windows wheel builds are left to CI; local validation covers installed-package configuration and generated metadata.

Prepared with OpenAI Codex assistance.

@hiyufan

hiyufan commented Nov 15, 2026

Copy link
Copy Markdown
Contributor Author

@tqchen, could you review this small follow-up to #20976? The unchanged pinned TIRx commit now has the final v0.1.0 tag, so source wheel builds resolve to 0.1.0 and the parent rejects them under its rc2/rc3-only bounds. Both macOS and Windows hit this before tests across all five refreshed PRs linked above.

The fix accepts the final release in CMake and both Python dependency bounds, while keeping the source pin and the upper limit at 0.1.0. Installed-package configuration and generated metadata validation pass locally; native CI has been triggered. Thank you.

tlopex pushed a commit that referenced this pull request Nov 15, 2026
With rank-one weights, `take(..., axis=0)` selects elements on the
MatMul reduction axis. Moving it after MatMul raises on vector
activations and changes results on matrix activations, even when the
output shape stays the same.

Require weight rank >= 2 in the simple column-selection rewrite. Leave
vector weights unchanged. Add two regressions and a positive control
showing that vector activations with matrix weights still rewrite.

Fixes #20595.

Validation against main `30fd3017fd`, Python 3.11, LLVM 21.1.8 and
source-built pinned TIRx/FFI dependencies:

- `test_transform_reorder_take_after_matmul.py`,
`test_transform_expand_matmul_of_sum.py`, and
`test_op_linear_algebra.py`: 26 passed.
- CPU C-backend VM execution against NumPy: 20/20 transformed cases
match values, shapes and dtypes. Covers vector/matrix/batched
activations, symbolic batch dimensions, and fast/clip/wrap take modes.
All 20 original modules also match the reference.
- File-scoped pre-commit checks passed.

Prepared with OpenAI Codex assistance. The build and validation above
were executed locally.

Includes the shared packaging fix in #20980: the pinned TIRx source now
carries the final `0.1.0` tag, which the old CMake/Python bounds
rejected on macOS and Windows. The pass/operator implementation is
unchanged by this CI follow-up. Fresh CI results are pending.
@tlopex

tlopex commented Nov 15, 2026

Copy link
Copy Markdown
Member

Closed as already included in #20815

@tlopex tlopex closed this Nov 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants