Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up of GHSA-xmq6-3c6q-fr8m: request values were written into cached operation metadata through
Parameter::setValue(). 4.4.9/5.0.8 fixed it with request-local copies, this removes the mutators so it cannot come back.Parameters::with(),without()andsorted()return a new instanceParameter(return $parameter->withValue($value)) or an operation holding it,ParameterProviderInterface::provide()now returnsOperation|Parameter|null(existing?Operationimplementations stay valid)ParameterProviderno longer overwrites the operation a provider returnedParameter::setValue()andParameters::add()/remove()/sort(), to be removed in 6.0Old providers calling
setValue()keep working with a deprecation. No measurable request-time cost (24-parameter operation: +0.2 ms at a ~7.4 ms median, below run-to-run noise).Docs: the Base64 link provider example in state-providers.md and the custom parameter provider prose in filters.md need to return
withValue(), separate PR.