Skip to content

docs(aisix): say config.proxy.workers also sizes the token-estimate pool - #429

Draft
jarvis9443 wants to merge 2 commits into
mainfrom
docs/aisix-workers-estimate-pool-1968
Draft

jarvis9443 wants to merge 2 commits into
mainfrom
docs/aisix-workers-estimate-pool-1968

Conversation

@jarvis9443

@jarvis9443 jarvis9443 commented Nov 15, 2026 •

Copy link
Copy Markdown
Contributor

Comment-only change to config.proxy.workers in charts/aisix/values.yaml (and the regenerated README): from api7/aisix#1437 the gateway sizes its token-estimate pool by proxy.workers too, and each pool thread holds one tokenizer instance per encoding it has counted with, about 17 MiB for cl100k, 27 MiB for o200k and 39 MiB for o200k_harmony. So workers, or a CPU limit when it is null, is what bounds that memory. No key or default changes.

Held for the release that ships api7/aisix#1437: the comment describes behaviour older gateways do not have.

🤖 Generated with Claude Code

@jarvis9443 jarvis9443 added the aisix-hold-for-release Gateway-key chart change: merges with the release that ships the key label Nov 15, 2026
@coderabbitai

coderabbitai Bot commented Nov 15, 2026 •

Copy link
Copy Markdown
Pre-merge checks: Passed 2

Check name Status Explanation
E2e Test Quality Review Passed The check is inapplicable to this pull request. It is a documentation-only change, so there is no test code or executable logic to review against the E2E, scenario-coverage, assertion, mocking, error-…
Security Check Passed The PR (api7/api7-helm-chart #429, author jarvis9443) changes only documentation. Its two commits, 2c4d252 and f16d111, touch charts/aisix/values.yaml (YAML comments only) and `charts/aisix/README.m…
Full details: E2e Test Quality Review

Explanation

The check is inapplicable to this pull request. It is a documentation-only change, so there is no test code or executable logic to review against the E2E, scenario-coverage, assertion, mocking, error-handling, or concurrency criteria. Evidence: - The PR-titled commits (2c4d252 and f16d111) change only two files: charts/aisix/values.yaml (comment lines around config.proxy.workers, currently lines 259-261) and charts/aisix/README.md (one generated line each). The diff adds and edits comments and does not change the workers: null default or any key. - Searching origin/main...HEAD for test, spec, e2e, .go, .py, or .ts files returned no matches. No test directories exist in the repository. - The PR description says the change is comment-only and is held until the release that ships api7/aisix#1437. No linked issue context was supplied, and the PR scope matches the single documented setting. Limitation: the local HEAD includes history beyond the PR's own commits, so the origin/main...HEAD stat also lists charts/aisix-cp files. Those files are not part of the PR's two commits, and the verdict does not depend on them. Because the PR adds no code or tests, no explicit failure condition in the check applies.

Full details: Security Check

Explanation

The PR (api7/api7-helm-chart #429, author jarvis9443) changes only documentation. Its two commits, 2c4d252 and f16d111, touch charts/aisix/values.yaml (YAML comments only) and charts/aisix/README.md (one docs table row). A filtered diff of those commits shows no non-comment, non-table lines. No key, default, template, or code path changes, so none of the seven security categories applies. Categories 1–7 cover logging, storage, authorization, ownership, TLS, resource isolation, and secret resolution. None of these is touched by a comment about config.proxy.workers memory use. The check's failure conditions are not met, so it passes. Note: the checkout HEAD also contains a later release commit (bcafd6b, version bump to 1.10.0, and a log_level default change). That commit is not part of this PR and was excluded from the assessment.

  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

aisix-hold-for-release Gateway-key chart change: merges with the release that ships the key

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant