Repository navigation
Preserve explicit empty-string arguments in OSC TCP clients - #200
Open
civilwarinfrance wants to merge 1 commit into
Open
civilwarinfrance wants to merge 1 commit into
civilwarinfrance wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
build_msg('/v', '')currently produces a message with no arguments. Both synchronous and asynchronous TCP clients use that helper, so an explicitly supplied empty string is silently dropped. The UDP client already sends it correctly. This can prevent an OSC receiver from clearing a string-valued control.Use an empty tuple for omitted values and let explicit strings follow the normal scalar path. Update both TCP defaults together so omitted values still produce argument-free messages. Add API documentation, a changelog entry and regression tests covering literal OSC bytes, both TCP clients, the existing UDP behavior, omitted values, empty iterables, zero, false, nil and generators.
Validation:
uv run mypy pythonosc examplespasses with its locked dependencies.Related: #95 established support for empty OSC strings; this fixes their handling in the newer shared message helper and TCP clients.
AI assistance was used to investigate, implement and test this change.