Skip to content

Name the template in 5 api-destinations deploy steps - #3541

Merged
julianwood merged 1 commit into
mainfrom
crew/serverless-patterns/api-destinations-templates
Nov 15, 2026
Merged

julianwood merged 1 commit into
mainfrom
crew/serverless-patterns/api-destinations-templates

Conversation

@julianwood

Copy link
Copy Markdown
Contributor

Five eventbridge-api-destinations variants have a template that isn't named template.yaml, so a plain sam deploy --guided doesn't find it. Their deploy step now names the file:

  • 4-mongodb: sam deploy --guided -t mongoDB.yaml
  • 5-zendesk: sam deploy --guided -t ZendeskAPIDestination.yaml
  • 6-freshdesk: sam deploy --guided -t FreshdeskAPIDestination.yaml
  • 7-datadog: sam deploy --guided -t DataDogApiDestination.yml
  • 9-shopify: sam deploy --guided -t ShopifyAPIDestination.yaml

The collection README says the same after its deploy step.

sam validate --lint failed on all five because of placeholder or empty parameter defaults (W1030), such as '<<ENTER YOUR UNIQUE URL HERE>>' and '' for API keys. Those defaults are removed and each parameter has a description, so a guided deploy asks for every value instead of offering a placeholder. All five now pass sam validate --lint, and node _scripts/validate.js passes. No resources change. Not deployed.

@julianwood julianwood added the migration Bulk repo change (e.g. folder migration). Skips the PatternsRotator; reviewed by maintainers. label Nov 15, 2026
@julianwood
julianwood merged commit 716e9ae into main Nov 15, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

migration Bulk repo change (e.g. folder migration). Skips the PatternsRotator; reviewed by maintainers.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant