Repository navigation
Name the template in 5 api-destinations deploy steps - #3541
Merged
julianwood merged 1 commit intoNov 15, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Five
eventbridge-api-destinationsvariants have a template that isn't namedtemplate.yaml, so a plainsam deploy --guideddoesn't find it. Their deploy step now names the file:4-mongodb:sam deploy --guided -t mongoDB.yaml5-zendesk:sam deploy --guided -t ZendeskAPIDestination.yaml6-freshdesk:sam deploy --guided -t FreshdeskAPIDestination.yaml7-datadog:sam deploy --guided -t DataDogApiDestination.yml9-shopify:sam deploy --guided -t ShopifyAPIDestination.yamlThe collection README says the same after its deploy step.
sam validate --lintfailed on all five because of placeholder or empty parameter defaults (W1030), such as'<<ENTER YOUR UNIQUE URL HERE>>'and''for API keys. Those defaults are removed and each parameter has a description, so a guided deploy asks for every value instead of offering a placeholder. All five now passsam validate --lint, andnode _scripts/validate.jspasses. No resources change. Not deployed.