Repository navigation
Conversation
The scout model string maps to new CameraTypes.SCOUT_CAMERA. Sensor type 21 is the same camera (its serial matches the camera uuid suffix in a real API capture), so it gets DeviceTypes.SCOUT_CAMERA. Regression tests use sanitized fixtures. Refs bachya#1186
bachya
approved these changes
Nov 11, 2026
| LOCK = 16 | ||
| OUTDOOR_CAMERA = 17 | ||
| MOTION_V2 = 20 | ||
| SCOUT_CAMERA = 21 |
Owner
There was a problem hiding this comment.
Small nit: let's keep these members alphabetized.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## dev #1198 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 16 16
Lines 1027 1029 +2
=========================================
+ Hits 1027 1029 +2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe what the PR does:
Adds recognition for the SimpliSafe Smart Alarm Wireless Indoor Camera, which the API reports as camera model
scoutand as sensor device type21.CameraTypes.SCOUT_CAMERA, mapped from model"scout"inMODEL_TO_TYPEDeviceTypes.SCOUT_CAMERA = 21Before this change, a system with one of these cameras logs
Unknown camera type: scoutandUnknown device type: 21on load (seen in Home Assistant 2026.11 with simplisafe-python 2026.09.0). I checked a captured API response from my own V3 system: the subscription's camera list has an entry with"model": "scout", and the sensors list has a"type": 21entry whose serial matches that camera's serial (the last 8 characters of its uuid). So type 21 is the same physical camera showing up in the sensors list.This only maps the types. It does not add live view or video support for scout. These cameras report
webRTCProvider: kvs, and I have not testedvideo_url()against one.Does this fix a specific issue?
Fixes #1186
Checklist:
README.mdwith any new documentation. (Not needed, the docs don't list camera types.)Tests: new
test_scout_cameraloads a V3 system with a scout camera added to the subscription and sensor fixtures, checks the camera type and sensor type, and asserts nothing is logged as unknown.test_device_type_21checks the raw mapping. Fixtures are built from a real capture with identifiers zeroed or redacted. Full suite passes at 100% coverage; ruff and mypy are clean.