[vadim-anfv]

Description

The --no-default-features build and clippy jobs are red on every open PR, including Markdown-only ones (#386, #387). The crates are unused there, and recent cargo flags that (unused_dependencies, warn by default) while the workflow passes build-warnings: deny.

cli-table is dropped entirely, as @tvpeter suggested: its last user, the payjoin session history, now returns JSON like the rest of the module.

payjoin history on master:

+------------+-----------------+---------------------+-------------------------------+
| Session ID | Sender/Receiver | Completed At        | Status                        |
+------------+-----------------+---------------------+-------------------------------+
| 1          | Receiver        | Not Completed       | Waiting for original proposal |
+------------+-----------------+---------------------+-------------------------------+
| 2          | Receiver        | 2026-11-13 17:50:42 | Session cancelled             |
+------------+-----------------+---------------------+-------------------------------+

and on this branch:

{
  "sessions": [
    {
      "id": "1",
      "role": "Receiver",
      "status": "Waiting for original proposal",
      "completed_at": null
    },
    {
      "id": "2",
      "role": "Receiver",
      "status": "Session cancelled",
      "completed_at": "2026-11-13 18:34:22"
    }
  ]
}

Throwaway test used to produce both outputs

Added to the tests module in src/handlers/payjoin/db.rs, not part of this PR. Only receiver sessions: a sender needs a PSBT and a v2 payjoin URI through SenderBuilder, which is a lot more setup.

cargo test --no-default-features --features rpc demo_history_output -- --nocapture

#[test]
fn demo_history_output() -> std::result::Result<(), Box<dyn std::error::Error>> {
    use crate::handlers::payjoin::PayjoinManager;
    use payjoin::bitcoin::{Address, secp256k1::PublicKey};
    use payjoin::{OhttpKeys, receive::v2::ReceiverBuilder};
    use std::str::FromStr;
    type R<T> = std::result::Result<T, Box<dyn std::error::Error>>;

    let dir = unique_test_datadir("demo");
    let db = open_payjoin_db(Some(dir.clone()), "demo")?;

    // key_id 0 || any valid secp256k1 point, here the generator
    let pk =
        PublicKey::from_str("0279be667ef9dcbbac55a06295ce870b07029bfcdb2dce28d959f2815b16f81798")?;
    let keys = OhttpKeys::try_from([&[0u8][..], &pk.serialize()].concat().as_slice())?;
    let addr = Address::from_str("tb1q6d3a2w975yny0asuvd9a67ner4nks58ff0q8g4")?.assume_checked();

    let new_session = |db| -> R<ReceiverPersister> {
        let p = ReceiverPersister::new(db)?;
        ReceiverBuilder::new(addr.clone(), "https://payjo.in", keys.clone())?
            .build()
            .save(&p)?;
        Ok(p)
    };

    new_session(db.clone())?;
    let closed = new_session(db.clone())?;
    closed.save_event(ReceiverSessionEvent::Closed(ReceiverSessionOutcome::Cancel))?;
    closed.close()?;

    println!("\n{}\n", PayjoinManager::history(Some(dir.clone()), "demo")?);
    let _ = std::fs::remove_dir_all(dir);
    Ok(())
}

Notes to the reviewers

An active session now reports "completed_at": null instead of the string Not Completed.

tracing is on cbf explicitly, although cbf already implies _payjoin-dependencies, so cbf logging does not depend on a payjoin-internal feature.

just pre-push misses this: the lint is cargo's, not rustc's, so -D warnings after -- does not apply. To reproduce: cargo build --no-default-features --config 'build.warnings="deny"'.

The SessionHistory wrapper exists to keep the field order: serializing it directly preserves declaration order, while json! would sort the keys alphabetically.

Checklists

All Submissions:

• I've signed all my commits
• I followed the contribution guidelines
• I ran cargo fmt and cargo clippy before committing

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 59.33%. Comparing base (12aae53) to head (eb9536d).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #389      +/-   ##
==========================================
- Coverage   59.50%   59.33%   -0.17%     
==========================================
  Files          25       25              
  Lines        4583     4562      -21     
==========================================
- Hits         2727     2707      -20     
+ Misses       1856     1855       -1     

Flag	Coverage Δ
rust	59.33% <100.00%> (-0.17%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[tvpeter]

Thank you @vadim-anfv for checking the CI failures.

I think we should get ride of cli-table since the pretty flag was dropped.

[tvpeter]

I just merged so you have conflicts. Also, update the PR title too. Thank you.

[vadim-anfv]

I just merged so you have conflicts. Also, update the PR title too. Thank you.

Rebased onto master, title updated, please have a look.

[tvpeter]

ACK eb9536d

Thank you.