Repository navigation
feat(staged): show project tags beside repos in the sidebar and grid - #1065
Merged
Merged
Conversation
Tags were easy to miss: sidebar rows showed none (only the icon group's tag, as the status icon), and grid cards put them on a row of their own, apart from the repos. A project's tags now sit as chips in the same cluster as its repo names: - Sidebar rows (ProjectRowContent, so also the move-branch and note-transfer pickers): after the repo short-name badges on the meta line, before any activity text. Up to two chips, then "+N" whose tooltip names the rest. A new `xs` TagChip size matches the small repo badge, so the row keeps its height. In a tight row a long tag name ellipsizes first; past that the line clips at the row's edge, as the repo badges already do. While no badge has landed, the chips follow the repo count instead. - Grid cards: in the footer's repo cluster, wrapping with the repos. Up to three chips, then "+N", as before. Both reuse the existing chip component and lookup, generalized: ProjectCardTagChips becomes ProjectTagChips (bare chips, with `max` and `size`), and ProjectRepoBadges becomes ProjectCardLabels, which renders the repos and then the chips. A project with no tags renders nothing extra. Board cards share that cluster and leave out the tag their column stands for. Readings chosen where the code differed from the request: - A board's columns are the tags of one tag group plus "No <group>", and a group is single choice, so the tag a column implies is the card's tag in the board's group. Cards already skipped that group's chip; that rule is kept (now `excludeTagGroupId`) and covered by tests. Cards under "No <group>" have no tag in the group and show every chip, as do tags from other groups in any column. - The icon group's tag is still not repeated as a chip anywhere: the project's status icon already shows it on every row and card. - The grid shows full repo paths rather than short names, so there the chips sit beside those. Tests: sidebar row and card-label component tests for chips beside the repos, no tags, multiple repos, overflow and the icon group; board tests for column-implied tags left off cards while other tags stay, including after a move and under "No <group>". Signed-off-by: Matt Toohey <contact@matttoohey.com> Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Tags were easy to miss: sidebar rows showed none, and grid cards put them on a row of their own, apart from the repos. A project's tags now sit as chips in the same cluster as its repo names.
ProjectRowContent, so also the move-branch and note-transfer pickers): chips follow the repo short-name badges on the meta line, before any activity text. Up to two chips, then "+N" with a tooltip naming the rest. A newxsTagChipsize matches the small repo badge so the row keeps its height. While no badge has landed, the chips follow the repo count instead.excludeTagGroupId). Cards under "No ‹group›" show every chip.Refactor
ProjectCardTagChips→ProjectTagChips: bare chips withmaxandsizeprops, no wrapper, so they wrap and shrink like the badges beside them.ProjectRepoBadges→ProjectCardLabels: renders the repos and then the chips.Tests
🤖 Generated with Claude Code