Repository navigation
ci: tag releases when a release PR merges (CB-593) - #214
Merged
Merged
Conversation
The push guard from the release-on-demand change never matched. After the 1.26.0 / 2.27.0 release PRs merged, the push run skipped the release-please job (sdk-python run 43488257883) even though the merge commit modifies .release-please-manifest.json, so contains(toJSON(github.event.commits.*.modified), ...) was false and nothing was tagged until Release Please was dispatched by hand. A paths filter on the push trigger does the same job off the pushed diff, so the job-level guard keeps only the repository check. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
spicysouvlaki
marked this pull request as ready for review
November 13, 2026 19:23
jtoar
approved these changes
Nov 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The push guard from browserbase/sdk-node#226 / #205 never matched, so merging a release PR tagged nothing (2.27.0 and 1.26.0 needed a manual dispatch). Trigger on a
pathsfilter for the manifest instead.🤖 Generated with Claude Code