Repository navigation
refactor: cleanup - #1959
Merged
Merged
refactor: cleanup#1959
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…xed check order The facade's modern-path argument handling (on-prefix stripping, arity check, prefix warning) was split between inline facade code and a generic src/events/utils.ts, and the null-instance check ran after the arity check. normalizeModernFireEventArgs() in src/events/fire-event-args.ts now runs them in a fixed order: strip prefix, check instance, check arity, warn on prefix. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
mdjastrzebski
force-pushed
the
refactor/cleanup
branch
from
November 5, 2026 16:25
a0901d5 to
c665618
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## next/event-system #1959 +/- ##
=====================================================
+ Coverage 98.91% 98.96% +0.04%
=====================================================
Files 105 107 +2
Lines 2313 2324 +11
Branches 617 614 -3
=====================================================
+ Hits 2288 2300 +12
+ Misses 24 23 -1
Partials 1 1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Promote to stable
Test plan