Repository navigation
Rejects setting numeric fields to numbers of another type in CelRuntime. - #1467
Open
copybara-service[bot] wants to merge 1 commit into
Open
copybara-service[bot] wants to merge 1 commit into
copybara-service[bot] wants to merge 1 commit into
Conversation
`TestAllTypes{single_uint64: dyn(-1)}` set the field to `18446744073709551615u`, and now fails, as the spec has no implicit conversions between int, uint, and double. Likewise for list elements, map keys and values, and wrapper messages such as `google.protobuf.UInt64Value{value: dyn(1)}`.
PiperOrigin-RevId: 1020507991
copybara-service
Bot
force-pushed
the
test_1020507991
branch
from
November 13, 2026 01:40
6a7ebcc to
2e12b64
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rejects setting numeric fields to numbers of another type in CelRuntime.
TestAllTypes{single_uint64: dyn(-1)}set the field to18446744073709551615u, and now fails, as the spec has no implicit conversions between int, uint, and double. Likewise for list elements, map keys and values, and wrapper messages such asgoogle.protobuf.UInt64Value{value: dyn(1)}.