Repository navigation
Conversation
Move the wrapper from Gradle 4.0.1 to 8.14.3 and replace the APIs that Gradle removed. Import com.cinchapi:cinchapi-bom:1.0.0 so the BOM supplies accent4j, Guava and JUnit. Run CircleCI on config version 2.1, with tests on Java 8 and Java 21.
Add Spotless with the Cinchapi Eclipse profile and import order from java-starter-kit. Spotless needs Java 17, so the build applies it only when Gradle runs on Java 17 or later; this build still runs on Java 8. The profile leaves header comments alone and there is no license header step, so every file keeps its copyright header. The sources already match the profile, so no file changes (0 of 2 Java files reformatted).
jtnelson
marked this pull request as ready for review
November 1, 2026 18:29
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
data-extract-api builds with Gradle 4.0.1, which predates
platform(), so it can't import the shared Cinchapi BOM, and CircleCI no longer runs itsversion: 2config, so pull requests get no build. This moves the build to Gradle 8.14.3, importscom.cinchapi:cinchapi-bom:1.0.0, runs CircleCI on config version 2.1 and adds the Cinchapi formatter, so the dependency updater can enroll the repo.Changes
compileandtestCompilebecomeapi,implementationandtestImplementation. Only the BOM isapi: no dependency type appears in the public API. Themavenplugin is gone;maven-publishalready published to Cloudsmith and keeps the same repositories and credentials.classifierbecomesarchiveClassifier, and thepublishingblock moves below the jars it publishes, because Gradle 8 no longer defers it.apiand declares accent4j, Guava and JUnit without versions, so it builds against accent4j 1.18.4, Guava 33.5.0-jre and JUnit 4.13.2. That replaces the explicit accent4j 1.18.4 this PR started with. The rule that excludes Guava from other dependencies now applies toimplementation. The published POM imports the BOM.options.release = 8keeps that target.cimg/openjdk:8.0.322andcimg/openjdk:21.0, with thecloudsmith-credscontext on every Gradle job../gradlew spotlessApplywith a JDK 17+JAVA_HOME). CI builds on Java 8 and does not check formatting, like relay-server and cinchapi-server. Copyright headers stay as they are: the profile's header-comment formatting is off, and there is no license-header step, which would replace each file's header with the starter kit's.Publishing
Unchanged: every branch publishes after its tests pass,
mastertoplatformand every other branch toplatform-snapshots; this branch published1.0.1-FEATURE-UPGRADE-ACCENT4J-1-18-4. A merge tomasterpublishes data-extract-api 1.0.1 toplatform, where 1.0.1 already exists (from 2021). The repository replaces packages by default, so the merge would overwrite that release with this build.For you to decide
.versionbefore merging, or accept that the merge overwrites 1.0.1 onplatform..versionis unchanged here.Notes
master, which brought in the shared version tool (Build and publish versions with the shared version tool #3).