Repository navigation
Run unit tests and cover the components - #140
Merged
Merged
Conversation
Guice rejects a class carrying both @singleton and @MojoExecutionScoped, which broke every plugin realm containing the jar. DefaultProgress takes a MojoExecution, so it is per-execution; do not add @singleton back. Fixes #127
Surefire had skipTests since the module only shipped test helpers; they are gone, so tests run again. ComponentScopeTest guards against #127 returning.
Base automatically changed from
agent/default-progress-single-scope
to
master
November 14, 2026 13:10
slachiewicz
marked this pull request as ready for review
November 14, 2026 13:11
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Turns test execution back on and adds JUnit 5 tests for the components, the wire format and the IPC server.
ComponentScopeTestfails on any indexed component with more than one scope annotation, which is how #127 shipped. Stacked on #139; retarget to master once that merges.Not covered: the IPC client, because its port is read once into a static field from a system property.
Verified:
mvn verify(Maven 3.9.16, JDK 17) → 42 tests pass; JaCoCo line coverage 441/502 (88%).ComponentScopeTestfails against theDefaultProgressfrom before #139.