Repository navigation
Conversation
substr counted length in UTF-16 units instead of code points, and from the start of the string instead of from `start`. This threw an IndexOutOfBoundsException when length was omitted or too large, and returned wrong or split characters when non-BMP characters came before `start`. Now length is clamped to the code points remaining after `start` and converted from there.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
substr counted length in UTF-16 units instead of code points, and from the start of the string instead of from
start. This threw an IndexOutOfBoundsException when length was omitted or too large, and returned wrong or split characters when non-BMP characters came beforestart. Now length is clamped to the code points remaining afterstartand converted from there.