Repository navigation
Use java.util.logging instead of System.out/err - #127
Merged
Merged
Conversation
Replace the dbg flag and the remaining System.out/err calls in Jsonata and Parser with the standard JDK logger. Debug tracing is logged at FINE and guarded by isLoggable, so it costs nothing when disabled. No new dependency is added. Alternative to #118. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Closed
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Alternative to #118 that uses the standard JDK logger (
java.util.logging) instead of slf4j, so the library stays dependency-free.Changes
Parser: thedbgflag is replaced by a static JULLogger.if (dbg) System.out.println(...)becomesif (log.isLoggable(Level.FINE)) log.fine(...), so tracing can be enabled via logging configuration and costs nothing when disabled.Jsonata: same for theparser.dbgchecks. The unconditionalSystem.out/System.errmessages are nowlog.warning("Proc not found ...")andlog.severe("Function not implemented ...").module-info.java:requires java.logging.LoggingTest: no records at the default level, andFINEtrace records fromParserandJsonatawhen enabled.Testing
mvn test: 1731 tests, 0 failures.🤖 Generated with Claude Code