Repository navigation
Port hot-path optimizations from #102 - #129
Merged
Merged
Conversation
- Tokenizer: compile the number regex once instead of per token
(matches the regex literal in jsonata-js); ~2.3x faster parsing of
number-heavy expressions after warmup
- Signature.validate: iterate chars instead of split(""), which compiled
a regex on every function call; build supplied signature with a
StringBuilder
- HotspotTest: correctness tests and timing loops for both paths
(-Dhotspot.iterations=N for longer runs)
Co-authored-by: Sergeev Viktor <sergeevViktor017@gmail.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This was referenced Nov 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Takes the two hot-path changes from #102 (thanks @sergeevik) and leaves the rest, to keep the code close to jsonata-js.
match.toCharArray()instead ofmatch.split(""), which compiled a regex on every function call. The supplied signature is built with aStringBuilder.-Dhotspot.iterations=Nfor longer runs.Timings at 500k iterations with warmup (JDK 25), two runs each:
The Signature change doesn't show up in end-to-end timings. On its own,
split("")takes about 150 ns per call andtoCharArray()about 4 ns. The change is kept to reduce allocations.The full test suite passes (1743 tests).
🤖 Generated with Claude Code