Skip to content

fix(cli): use relative path for local directory log message - #111

Open
saicharan13245-ship-it wants to merge 1 commit into
dbpedia:mainfrom
saicharan13245-ship-it:fix-data-location
Open

saicharan13245-ship-it wants to merge 1 commit into
dbpedia:mainfrom
saicharan13245-ship-it:fix-data-location

Conversation

@saicharan13245-ship-it

@saicharan13245-ship-it saicharan13245-ship-it commented Nov 11, 2026 •

Copy link
Copy Markdown

Pull Request

Description

Wrapped the directory output in os.path.relpath() so the CLI prints a clean relative path instead of a confusing absolute path for Docker mounts

Related Issues
Fixes issue #68

Type of change

  • [ x] Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • This change requires a documentation update
  • Housekeeping

Checklist:

  • [ x] My code follows the ruff code style of this project.
  • [ x] I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (if applicable)
  • I have added tests that prove my fix is effective or that my feature works
  • [x ] New and existing unit tests pass locally with my changes
    • [x ] poetry run pytest - all tests passed
    • [x ] poetry run ruff check - no linting errors

Summary by CodeRabbit

  • Bug Fixes
    • When a download directory isn’t specified, the selected directory is now displayed as a path relative to the current working directory rather than as a full path. Download behavior is unchanged.

@coderabbitai

coderabbitai Bot commented Nov 11, 2026 •

Copy link
Copy Markdown

Explain Change →

No actionable comments were generated in the recent review.

Walkthrough

When no localDir is supplied, the missing-directory message now displays the selected directory as a path relative to the current working directory.

Changes: Download directory message

Layer / File(s) Summary
Display relative directory path
databusclient/api/download.py
The missing-directory message displays localDir relative to the current working directory.

Estimated code review effort: 1 (Trivial) | ~3 minutes

Change: Bug fix

Suggested reviewers: integer-ctrl

Merge Risk: Minimal · up to d6412

The CLI now prints a relative directory path in the missing-directory message. This is a display-only change with no meaningful merge risk.

Pre-merge checks: Passed 5

Check name Status Explanation
Title check Passed The title clearly and concisely identifies the main change: using a relative path in the CLI local-directory log message.
Description check Passed The description follows the required template. It explains the change, links issue #68, identifies the change as a bug fix, and reports test and lint results. Unchecked documentation, comments, and ad…
Docstring Coverage Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Description check

Explanation

The description follows the required template. It explains the change, links issue #68, identifies the change as a bug fix, and reports test and lint results. Unchecked documentation, comments, and added-test items are non-critical for this small change.

Full details: Docstring Coverage

Explanation

Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 1 functions across 1 files.

Finishing Touches

Generate unit tests (beta)

  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

Recent review info

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: d4b0a9cb-de34-4f2f-abe6-87a238c3659f
Commits

Reviewing files that changed from the base of the PR and between 70fb67f and d64123a.

Files selected for processing: 1

  • databusclient/api/download.py

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant