Skip to content

mpi: Emit global index offsets on a single rank and rebuild Functions onto SubGrids - #3110

Open
mloubout wants to merge 2 commits into
mainfrom
mloubout/subgrid-rebuild
Open

mloubout wants to merge 2 commits into
mainfrom
mloubout/subgrid-rebuild

Conversation

@mloubout

Copy link
Copy Markdown
Contributor

Code generated with MPI on one rank (e.g. the DevitoPRO decoupler) now carries the global index and SubGrid offsets, and Function._rebuild(grid=subgrid) moves onto the SubGrid's Dimensions.

@codecov

codecov Bot commented Nov 12, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 64.51613% with 55 lines in your changes missing coverage. Please review.
✅ Project coverage is 84.29%. Comparing base (f658db9) to head (3d7e391).

Files with missing lines Patch % Lines
tests/test_subsampling.py 47.22% 38 Missing ⚠️
tests/test_mpi.py 15.38% 11 Missing ⚠️
devito/types/dimension.py 76.92% 3 Missing ⚠️
devito/mpi/distributed.py 88.88% 1 Missing and 1 partial ⚠️
devito/ir/equations/algorithms.py 80.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3110      +/-   ##
==========================================
- Coverage   84.34%   84.29%   -0.06%     
==========================================
  Files         260      260              
  Lines       59083    59210     +127     
  Branches     4996     5002       +6     
==========================================
+ Hits        49836    49909      +73     
- Misses       8416     8470      +54     
  Partials      831      831              
Flag Coverage Δ
pytest-gpu-aomp-amdgpuX 68.38% <67.14%> (-0.03%) ⬇️
pytest-gpu-gcc- 79.05% <64.51%> (-0.05%) ⬇️
pytest-gpu-icx- 78.97% <64.51%> (-0.08%) ⬇️
pytest-gpu-nvc-nvidiaX 69.24% <67.14%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mloubout mloubout added the API api (symbolics, types, ...) label Nov 12, 2026
@mloubout
mloubout force-pushed the mloubout/subgrid-rebuild branch from 50757cb to 739178a Compare November 12, 2026 21:30
@mloubout
mloubout force-pushed the mloubout/subgrid-rebuild branch from 563e80c to 3d7e391 Compare November 13, 2026 02:37
@review-notebook-app

Copy link
Copy Markdown

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

API api (symbolics, types, ...)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant