Skip to content

Drop dead terminal-state and build-viewer code, and correct four stale comments and docs - #1610

Open
dormouse-bot wants to merge 1 commit into
mainfrom
nightly/dead-code-stale-docs
Open

dormouse-bot wants to merge 1 commit into
mainfrom
nightly/dead-code-stale-docs

Conversation

@dormouse-bot

@dormouse-bot dormouse-bot commented Nov 8, 2026 •

Copy link
Copy Markdown
Collaborator

This PR deletes dead code and fixes stale text that tonight's nightly survey found. Nothing here changes runtime behavior. The only code-path edit replaces a duplicated scan with the function it copied. Existing tests cover it: the terminal-state tests (281) pass, and so do lib typecheck, dor-tools-builtin build, lint:specs, and lint:md.

  • lib/src/lib/terminal-state.ts:
    • DEFAULT_TERMINAL_PANE_STATE has no importers. It also still set title: null, a field TerminalPaneState no longer has. Object.freeze hid that from excess-property checks.
    • snapshotInRunTerminalTitle was a line-for-line copy of findInRunTerminalTitle with an explicit upper bound. The commandFinish reducer now calls findInRunTerminalTitle(state, { ...currentCommand, finishedAt }), so the two in-run title scans can't drift apart.
  • dor-tools-builtin/scripts/build-viewer.mjs: the node scripts/build-viewer.mjs <outdir> entry has no caller. scripts/build.mjs and website/scripts/build-builtin-viewer.js both import buildViewerAssets.
  • lib/src/components/wall/chrome-keyboard-lease.ts: the comment listed only the strip's rename editor and close confirmation as lease holders. WorkspaceStrip also takes the lease for its move error and tab menu, and standalone/src/quit-confirm-store.ts takes it for quit.
  • SECURITY.md: it linked a "Domains table" in security.md, but that section is prose with no table. The link text now names the section.
  • docs/specs/security-ci.rationale.md: the text said "eight" workflows pass anthropic_api_key, but seven do. The count is now dropped rather than corrected, so it can't go stale again.
  • .gitignore: removes the Chromatic outputs. Nothing produces them since the Chromatic workflow was removed.

Unresolved: Argos. argos/storybook-webkit reports "1 changed — waiting for your decision" (build 2389), and a rerun gave the same result. argos/storybook-chromium reports no change. I can't open the Argos build from CI, so I haven't seen which story changed. The only bundled edits are a comment and the commandFinish refactor. The refactor passes the same startedAt/finishedAt bounds to the same scan over titleCandidates, and Chromium shows no diff. So a WebKit-only render difference is the likelier cause, but I haven't confirmed that. Every other CI check is green.

…e comments and docs

- terminal-state: delete the unused DEFAULT_TERMINAL_PANE_STATE (it still set a
  title field TerminalPaneState no longer has) and the snapshotInRunTerminalTitle
  copy of findInRunTerminalTitle; commandFinish calls the latter with finishedAt.
- build-viewer.mjs: delete its uncalled command-line entry; both callers import
  buildViewerAssets.
- chrome-keyboard-lease: the lease holders now include strip menus and host
  confirmations such as quit.
- SECURITY.md: security.md has no Domains table; name the section it links.
- security-ci.rationale: drop the workflow count, which was eight against seven.
- .gitignore: drop the Chromatic outputs nothing produces since its removal.
@cloudflare-workers-and-pages

Copy link
Copy Markdown

Deploying mouseterm with  Cloudflare Pages  Cloudflare Pages

Latest commit: 49bc9b6
Status: ✅  Deploy successful!
Preview URL: https://d9ba71e1.mouseterm.pages.dev
Branch Preview URL: https://nightly-dead-code-stale-docs.mouseterm.pages.dev

View logs

@dormouse-bot dormouse-bot left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

argos/storybook-webkit (and so argos/summary) is red on this head: build 2386. This diff changes no rendered output. The only runtime edit swaps snapshotInRunTerminalTitle for findInRunTerminalTitle, which runs the same scan with the same bound. Argos webkit diffs also failed on four of the last six main commits (for example f2b8600be89d70ab906b67e856dd6466dc0bb8dc), so a maintainer needs to accept or reject the build in Argos. No code change follows from it. Every GitHub Actions check passed.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant