Repository navigation
Drop dead terminal-state and build-viewer code, and correct four stale comments and docs - #1610
Open
dormouse-bot wants to merge 1 commit into
Open
dormouse-bot wants to merge 1 commit into
dormouse-bot wants to merge 1 commit into
Conversation
…e comments and docs - terminal-state: delete the unused DEFAULT_TERMINAL_PANE_STATE (it still set a title field TerminalPaneState no longer has) and the snapshotInRunTerminalTitle copy of findInRunTerminalTitle; commandFinish calls the latter with finishedAt. - build-viewer.mjs: delete its uncalled command-line entry; both callers import buildViewerAssets. - chrome-keyboard-lease: the lease holders now include strip menus and host confirmations such as quit. - SECURITY.md: security.md has no Domains table; name the section it links. - security-ci.rationale: drop the workflow count, which was eight against seven. - .gitignore: drop the Chromatic outputs nothing produces since its removal.
Deploying mouseterm with
|
| Latest commit: |
49bc9b6
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://d9ba71e1.mouseterm.pages.dev |
| Branch Preview URL: | https://nightly-dead-code-stale-docs.mouseterm.pages.dev |
dormouse-bot
commented
Nov 8, 2026
dormouse-bot
left a comment
Collaborator
Author
There was a problem hiding this comment.
argos/storybook-webkit (and so argos/summary) is red on this head: build 2386. This diff changes no rendered output. The only runtime edit swaps snapshotInRunTerminalTitle for findInRunTerminalTitle, which runs the same scan with the same bound. Argos webkit diffs also failed on four of the last six main commits (for example f2b8600be89d70ab906b67e856dd6466dc0bb8dc), so a maintainer needs to accept or reject the build in Argos. No code change follows from it. Every GitHub Actions check passed.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR deletes dead code and fixes stale text that tonight's nightly survey found. Nothing here changes runtime behavior. The only code-path edit replaces a duplicated scan with the function it copied. Existing tests cover it: the terminal-state tests (281) pass, and so do
libtypecheck,dor-tools-builtinbuild,lint:specs, andlint:md.lib/src/lib/terminal-state.ts:DEFAULT_TERMINAL_PANE_STATEhas no importers. It also still settitle: null, a fieldTerminalPaneStateno longer has.Object.freezehid that from excess-property checks.snapshotInRunTerminalTitlewas a line-for-line copy offindInRunTerminalTitlewith an explicit upper bound. ThecommandFinishreducer now callsfindInRunTerminalTitle(state, { ...currentCommand, finishedAt }), so the two in-run title scans can't drift apart.dor-tools-builtin/scripts/build-viewer.mjs: thenode scripts/build-viewer.mjs <outdir>entry has no caller.scripts/build.mjsandwebsite/scripts/build-builtin-viewer.jsboth importbuildViewerAssets.lib/src/components/wall/chrome-keyboard-lease.ts: the comment listed only the strip's rename editor and close confirmation as lease holders.WorkspaceStripalso takes the lease for its move error and tab menu, andstandalone/src/quit-confirm-store.tstakes it for quit.SECURITY.md: it linked a "Domains table" insecurity.md, but that section is prose with no table. The link text now names the section.docs/specs/security-ci.rationale.md: the text said "eight" workflows passanthropic_api_key, but seven do. The count is now dropped rather than corrected, so it can't go stale again..gitignore: removes the Chromatic outputs. Nothing produces them since the Chromatic workflow was removed.Unresolved: Argos.
argos/storybook-webkitreports "1 changed — waiting for your decision" (build 2389), and a rerun gave the same result.argos/storybook-chromiumreports no change. I can't open the Argos build from CI, so I haven't seen which story changed. The only bundled edits are a comment and thecommandFinishrefactor. The refactor passes the samestartedAt/finishedAtbounds to the same scan overtitleCandidates, and Chromium shows no diff. So a WebKit-only render difference is the likelier cause, but I haven't confirmed that. Every other CI check is green.