Repository navigation
Count watches, not attaches, in the requestInit no-re-watch test - #1611
Open
dormouse-bot wants to merge 1 commit into
Open
dormouse-bot wants to merge 1 commit into
dormouse-bot wants to merge 1 commit into
Conversation
The test named 'requestInit re-emits the cached list without re-watching' asserted only that nothing attached, so a broken #watchPromise memo that re-subscribed on every requestInit still passed. It now spies on watchDirectory and expects exactly one call.
Deploying mouseterm with
|
| Latest commit: |
12bc9a4
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://db62f5e5.mouseterm.pages.dev |
| Branch Preview URL: | https://nightly-remote-adapter-rewat.mouseterm.pages.dev |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
RemotePtyAdaptertest titled "requestInit re-emits the cached list without re-watching" never checked for re-watching. Its only guard wasexpect(client.attaches).toHaveLength(0), andFakeClient.watchDirectoryrecords nothing, so the test stayed green even ifrequestInitsubscribed to the Burrow directory again. Only the#watchPromisememo in#ensureDirectoryWatchprevents that re-subscribe. The test now spies onwatchDirectoryand expects exactly one call.To verify, I replaced the memo check with
if (true)and the test failed (toHaveBeenCalledTimes(1)). With the code restored, all 28 tests in the file pass. This PR changes no production code.