Repository navigation
fix: drive the pairing walkthrough through Pocket's composer and Sessions screen - #1613
Open
dormouse-bot wants to merge 1 commit into
Open
dormouse-bot wants to merge 1 commit into
dormouse-bot wants to merge 1 commit into
Conversation
…ions screen The happy scenario still waited on the Type reserve's focus button and the input-mode selector, both removed by the mobile redesign (f3072ab), so connectPocket timed out. The helpers now open the composer from the touch-mode bar's Type button, send with its Send button, and read rows and the way out from the full-screen Sessions screen. Closes #1612
Deploying mouseterm with
|
| Latest commit: |
f99b350
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://09196888.mouseterm.pages.dev |
| Branch Preview URL: | https://fix-issue-1612.mouseterm.pages.dev |
This was referenced Nov 8, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The pairing walkthrough's
happyscenario stalled atconnectPocket. It waited for the Type reserve'sFocus terminal inputbutton and later clicked theType input mode/Sessions input modeselector. The mobile redesign (f3072ab) removed all of them, so the step would time out after 120 s. The Pocket helpers inscripts/pairing-walkthrough/steps.mjsnow use the current composition (lib/src/components/MobileTerminalUi.tsx):Typebutton insidesection[aria-label="Touch mode"], plus.xterm. The selector is scoped to the bar because the composer dialog is also labelledType.[data-mobile-composer]textarea,inserttext, then click the composer's Send. Pressing Enter in that textarea would only add a newline. Send closes the composer, so the existing spare-Enter retries reach the terminal through the physical-keyboard path. If the Sessions screen is open, the helper first pressesBack to terminal, because the composer closes on that screen.Show sessionstitle, then read rows from the screen's list block. A ringing row is still detected by[data-alert-ring-inset].sessionsHeader. The step opens that screen and clickssection[aria-label="Sessions"] header button.The stale
mobile-terminal-ui.md→ "Keyboard focus" citation now names "Keyboard focus invariant".Verification, and its limit. I have not run the walkthrough itself. The CI sandbox refuses
AF_UNIXsockets (socket(AF_UNIX, …) = EAFNOSUPPORT), and both agent-browser's daemon and Chrome's process singleton need them, so neither browser can start. Instead, a throwaway jsdom test (not committed) rendered Pocket's realConnectedView→PocketWall→MobileTerminalUi, with onlyTerminalPaneand the terminal registry mocked. It ran the helper expressions read verbatim out ofsteps.mjsand passed every stage:doPasteand then writing\rwriteUserInput777;notifyrow found on the Sessions screenBack to terminalfollowed by TypeonLeavejsdom does not show whether agent-browser's CDP click on Type opens a focused composer in real Chrome, or whether
inserttextlands in it. Onenode scripts/pairing-walkthrough/run.mjson a machine with Chrome would settle that.Closes #1612 — automated triage