Skip to content

fix: drive the pairing walkthrough through Pocket's composer and Sessions screen - #1613

Open
dormouse-bot wants to merge 1 commit into
mainfrom
fix/issue-1612
Open

dormouse-bot wants to merge 1 commit into
mainfrom
fix/issue-1612

Conversation

@dormouse-bot

Copy link
Copy Markdown
Collaborator

The pairing walkthrough's happy scenario stalled at connectPocket. It waited for the Type reserve's Focus terminal input button and later clicked the Type input mode/Sessions input mode selector. The mobile redesign (f3072ab) removed all of them, so the step would time out after 120 s. The Pocket helpers in scripts/pairing-walkthrough/steps.mjs now use the current composition (lib/src/components/MobileTerminalUi.tsx):

  • Wall ready: the Type button inside section[aria-label="Touch mode"], plus .xterm. The selector is scoped to the bar because the composer dialog is also labelled Type.
  • Typing a command: click Type, check that focus is in the [data-mobile-composer] textarea, inserttext, then click the composer's Send. Pressing Enter in that textarea would only add a newline. Send closes the composer, so the existing spare-Enter retries reach the terminal through the physical-keyboard path. If the Sessions screen is open, the helper first presses Back to terminal, because the composer closes on that screen.
  • Ring check: open the Sessions screen through the wall header's Show sessions title, then read rows from the screen's list block. A ringing row is still detected by [data-alert-ring-inset].
  • Leave and reconnect: the "‹ Burrows" button is now only on the Sessions screen, in Pocket's sessionsHeader. The step opens that screen and clicks section[aria-label="Sessions"] header button.

The stale mobile-terminal-ui.md → "Keyboard focus" citation now names "Keyboard focus invariant".

Verification, and its limit. I have not run the walkthrough itself. The CI sandbox refuses AF_UNIX sockets (socket(AF_UNIX, …) = EAFNOSUPPORT), and both agent-browser's daemon and Chrome's process singleton need them, so neither browser can start. Instead, a throwaway jsdom test (not committed) rendered Pocket's real ConnectedView → PocketWall → MobileTerminalUi, with only TerminalPane and the terminal registry mocked. It ran the helper expressions read verbatim out of steps.mjs and passed every stage:

  • the wall-ready check
  • the composer taking focus
  • Send handing the text to doPaste and then writing \r
  • a spare Enter reaching writeUserInput
  • a ringing 777;notify row found on the Sessions screen
  • Back to terminal followed by Type
  • the back button calling onLeave

jsdom does not show whether agent-browser's CDP click on Type opens a focused composer in real Chrome, or whether inserttext lands in it. One node scripts/pairing-walkthrough/run.mjs on a machine with Chrome would settle that.

Closes #1612 — automated triage

…ions screen

The happy scenario still waited on the Type reserve's focus button and the
input-mode selector, both removed by the mobile redesign (f3072ab), so
connectPocket timed out. The helpers now open the composer from the
touch-mode bar's Type button, send with its Send button, and read rows and
the way out from the full-screen Sessions screen.

Closes #1612
@cloudflare-workers-and-pages

Copy link
Copy Markdown

Deploying mouseterm with  Cloudflare Pages  Cloudflare Pages

Latest commit: f99b350
Status: ✅  Deploy successful!
Preview URL: https://09196888.mouseterm.pages.dev
Branch Preview URL: https://fix-issue-1612.mouseterm.pages.dev

View logs

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Pairing walkthrough happy scenario waits on Pocket input-mode controls the mobile redesign removed

1 participant