Repository navigation
SDK mac_addresses() and the MCP status MACs - #94
Merged
Merged
Conversation
BenchPod.mac_addresses() returns MacAddresses (eth_mac, wifi_mac, has_wifi, source): from the pod's status (firmware after 3.10.7: eth_mac, wifi_mac), else from embeddedci.com's record of the pod (net.eth_mac, net.wifi_mac), which is how a cloud connection gets them. The MCP status tool reports eth_mac and wifi_mac. For a network that hands out addresses only to registered devices. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For a network that hands out addresses only to registered devices (tester feedback item 1).
BenchPod.mac_addresses(status=None)returnsMacAddresses(eth_mac,wifi_mac,has_wifi,source): from the pod's status (eth_mac,wifi_mac, firmware after 3.10.7; LAN and USB), else from embeddedci.com's record of the pod (net.eth_mac,net.wifi_mac, recorded at ship time and refreshed on connect), which is how a cloud connection gets them (the cloud status is the short form, without them).statusreportseth_macandwifi_mac.Tests: embeddedci 890 passed, embeddedci-mcp 205 passed locally; new tests for the status path, the server fallback and the MCP fields.
Pairs with embeddedci-com/benchpod-firmware#153 and embeddedci-com/benchpod-cli#62.
🤖 Generated with Claude Code