Repository navigation
UART parity and stop bits (SDK + MCP), latin-1 UART sessions - #95
Merged
Merged
Conversation
open_uart, capture_uart and power_cycle_and_capture take parity (none/even/odd) and stop_bits (1/2); the MCP's uart_open, capture_uart and power_cycle_and_capture too. Anything but 8N1 needs the pod's uart_frame capability (firmware 3.10.8+, gateware v56) and is refused before anything is sent on older firmware. The TCP transport sends the fields only for a non-8N1 frame; the USB console stays 8N1. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
A UART session decoded everything as UTF-8 with replacement, so a Modbus RTU frame with bytes above 0x7F came back mangled. encoding latin-1 maps each byte to one character and back. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Parity and stop bits are described as frame settings, not Modbus support; where Modbus RTU comes up, the docs say it needs an external RS-485 transceiver (and 5 V serial a level shifter). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
wardviaene
force-pushed
the
uart-parity
branch
from
November 17, 2026 02:30
8d02bab to
f85179e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tester feedback item 5 (5 V serial and Modbus RTU).
open_uart,capture_uart,power_cycle_and_capturetakeparity(none/even/odd) andstop_bits(1/2). Anything but 8N1 needs the pod's newuart_framecapability (firmware 3.10.8+, gateware v56) and raisesUnsupportedFeatureError("UART parity and stop bits need firmware 3.10.8+ ...") before anything is sent. The TCP transport adds the fields only for a non-8N1 frame; the USB console transport stays 8N1 and refuses others.open_uart(encoding="latin-1"): binary-safe sessions (a Modbus frame with bytes above 0x7F came back mangled by the UTF-8 decoder).uart_open,capture_uart,power_cycle_and_capturetakeparityandstop_bits;uart_openreports them. Old SDKs keep working for 8N1.UART_FRAME_FIRMWARE = "3.10.8"assumes the firmware PR ships in the next patch release; adjust at release time if not.Goes with embeddedci-com/benchpod-firmware (uart-parity), embeddedci-com/benchpod-ui (uart-parity) and the server's web terminal + docs page.
🤖 Generated with Claude Code