Repository navigation
🐛 FIX: Preserve IPv6 host brackets in normalized URLs - #459
Open
Jinyong-Li wants to merge 1 commit into
Open
Jinyong-Li wants to merge 1 commit into
Jinyong-Li wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Rendering
[app](http://[::1]:8000/)currently produces anhrefofhttp://%5B::1%5D:8000/. The brackets delimit the IPv6 host and need to survive URL normalization.Encode the URL components before
mdurl.format()adds the host brackets. This keeps brackets in paths, queries and fragments percent-encoded. The regression cases cover inline links, scheme-relative links, autolinks and images.This ports the behavior from markdown-it/markdown-it#1204.
Testing
tox -e py312 -x 'testenv.pass_env+=PYTHONUTF8' -- tests/ -qwithPYTHONUTF8=1on Windows passed all 1,036 tests.pre-commit run --all-filespassed, including Ruff and mypy.