Repository navigation
FIX @W-24886726@ [BUG][code-analyzer] ESLint LWC base config runs on Aura controllers and reports correct Aura code - #522
Open
nikhil-mittal-165 wants to merge 3 commits into
Conversation
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
|
Git2Gus App is installed but the |
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
nikhil-mittal-165
marked this pull request as ready for review
November 12, 2026 12:40
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
aruntyagiTutu
approved these changes
Nov 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Addresses code-analyzer issue 2112.
Root Cause
In code-analyzer-core's ESLint engine, base-config.ts (createJavascriptPlusLwcConfigArray, ~L143-181) applies the LWC, LWC-platform, Lightning, import and Jest configs and the eslintJs.configs.all base JS config to every .js/.cjs/.mjs file with no exclusion for /aura/ folders. Aura controllers (ES5, $A API, not LWC) therefore get false positives such as @lwc/lwc-platform/no-aura, @lwc/lwc/no-document-query, no-var and prefer-const. createJavascriptConfigArray has the same unconditional patterns. Not user error: it happens with default settings and documented flags on 5.16.0, and disable_lwc_base_config / file_extensions cannot separate Aura from LWC files.
Fix
Excluded /aura/ files from JS and LWC base ESLint configs so Aura controllers no longer get LWC false positives.
Testing
Functional Testing Evidence
Test 1: Aura controller (issue repro, eslint:Recommended, no config) via
sf code-analyzer run --workspace . --rule-selector eslint:Recommended- no ESLint violations on aura/accountList/accountListController.js (no no-aura, no-document-query, no-var, prefer-const) - PASSTest 2: Control LWC file in same run still reports eslint:no-var and eslint:@lwc/lwc/no-document-query on myLwc.js (exclusion limited to Aura) - PASS
Unrelated PMD/SFGE engine errors from missing Java.
Overall Status: PASS
Files Changed
🤖 Generated with Claude Code